Migrate all VaultsSecrets handlers to RawHandler #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms, adding some prototype tests to scratch.test.ts to test vtar functionality
CDeltakai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the following VaultsSecrets handlers to use RawHandler instead of DuplexHandler which will allow handlers to directly transfer binary data instead of first being turned into JSON. It will also use js-virtualtar in order to pack desired files into tars before sending it across the stream, where it will be unpacked by a parser also provided by js-virtualtar.
Issues Fixed
VaultsSecretshandlers toRawHandler#822tararchival format to transfer file tree structure and data between Polykey vaults and local file systems #811Tasks
VaultsSecretsCatVaultsSecretsWriteFileVaultsSecretsEnvFinal checklist