Add basic changelog API support#68
Open
Chiffario wants to merge 1 commit into
Open
Conversation
Adds support for /changelog and /changelog/{stream}/{build} with
baseline coverage
MaxOhn
requested changes
May 11, 2026
Owner
MaxOhn
left a comment
MaxOhn
left a comment
There was a problem hiding this comment.
Got some minor nits and clippy seems to be angery currently. Other than that, looks good
Comment on lines
+8
to
+9
| #[derive(Clone, Debug, Deserialize)] | ||
| pub struct ChangelogListing { |
Owner
There was a problem hiding this comment.
Should add the attribute #[cfg_attr(feature = "serialize", derive(serde::Serialize))] to this and other types
| /// User related types | ||
| pub mod user; | ||
|
|
||
| pub mod changelog; |
Owner
There was a problem hiding this comment.
The module is public, a simple comment for documentation would be nice even if it's trivial
Comment on lines
+56
to
+57
| // There are only two supported formats, it should be fine | ||
| message_formats: Vec::with_capacity(2).into(), |
Owner
There was a problem hiding this comment.
We never push into the Vec, its setter overwrites it. Vec::new should be sufficient here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for /changelog and /changelog/{stream}/{build} with baseline coverage. Not entirely sure on cleanliness, but this should be good enough as a base
Handy for user count data by the way