Skip to content

fix(ci): a four-line lockfile bump, and a held bump can be resumed (#25) - #26

Merged
Maxaubert merged 1 commit into
mainfrom
fix/25-bump-lockfile
Sep 19, 2026
Merged

Maxaubert merged 1 commit into
mainfrom
fix/25-bump-lockfile

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Closes #25. Found by the first live run of core-release (the dictation merge, Prism #165).

What the first run showed

It worked end to end: it tagged core-v0.2.0, opened Prism #165 with the right version (0.54.1, a patch), waited for Prism's checks, and refused to merge because the terminal gate was red. Two things were wrong around it:

  1. The lockfile. npm install --package-lock-only on the Linux runner rewrote about 300 unrelated lines of Prism's lock (a different npm drops every libc field; lock-only mode invents bundled entries even under the owner's own npm, measured). A pin bump is four lines. The workflow now EDITS the lock: the pin, the commit the tag resolves to (git ls-remote), and the core's own version and peer ranges read from the released core. It refuses to push if the edit touches more than 12 lines. Verified by running the exact snippet against Prism's real lockfile: 4 lines, identical to the hand edit that is on fix(core): a hovered link on the alternate screen keeps its colour (#163) #165 now.
  2. No way to resume. The gate's red was a flaky scrollback check in Prism (fixed on fix(core): a hovered link on the alternate screen keeps its colour (#163) #165, per the owner's ratchet rule), but a held bump could not be picked up again: a re-run saw the branch and exited, and a manual run skipped the bump job. Now an existing branch with an open PR is RESUMED (never rebuilt: a person may have pushed a fix onto it), and workflow_dispatch runs the bump job.

No app or core change, so no version bump: release.yml will say v0.2.0 is already released and publish nothing.

🤖 Generated with Claude Code

…ting it, and a held bump can be resumed (#25)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Maxaubert
Maxaubert merged commit 5b91dd0 into main Sep 19, 2026
2 checks passed
@Maxaubert
Maxaubert deleted the fix/25-bump-lockfile branch September 19, 2026 20:56
Maxaubert added a commit that referenced this pull request Sep 25, 2026
…2e harness (#71) (#72)

Settings: the colour editor saves the whole setup into Custom and is a theme
pick (#8, #29); ThemeSwitchAsk registers once (#22); a hex field commits only
a changed draft (#26); the dictation key is never a key that types or a chord
the terminal owns, and a press elsewhere ends the capture (#27); the editor
takes the focus, traps Tab and hears Escape, the pencil is its own button
(#28); a finished download reads fresh state before picking the model (#30).

Release and CI: release.yml tags the built commit (#11); core-release runs
from main only (#34), waits for terminal-gate by name and its success (#38),
and opens an issue when a core change cannot be released; core-version also
requires the core version above the base's (#39).

Harness: a time limit per scenario and closeApp (#35), profiles removed after
each scenario (#36), the poll's first verdict awaited instead of 6 s (#37).

Core 0.15.3, app 0.18.3. New reviewSettings e2e and unit tests.


Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2026
…2e harness (#71) (#72)

Settings: the colour editor saves the whole setup into Custom and is a theme
pick (#8, #29); ThemeSwitchAsk registers once (#22); a hex field commits only
a changed draft (#26); the dictation key is never a key that types or a chord
the terminal owns, and a press elsewhere ends the capture (#27); the editor
takes the focus, traps Tab and hears Escape, the pencil is its own button
(#28); a finished download reads fresh state before picking the model (#30).

Release and CI: release.yml tags the built commit (#11); core-release runs
from main only (#34), waits for terminal-gate by name and its success (#38),
and opens an issue when a core change cannot be released; core-version also
requires the core version above the base's (#39).

Harness: a time limit per scenario and closeApp (#35), profiles removed after
each scenario (#36), the poll's first verdict awaited instead of 6 s (#37).

Core 0.15.3, app 0.18.3. New reviewSettings e2e and unit tests.


Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The bump workflow churns Prism's lockfile, and cannot resume a held bump

1 participant