Repository navigation
Settings: neutral controls, only Save keeps the accent (#42) - #43
Merged
Merged
Conversation
…#42) Row buttons take the dropdown's look, a pressed segment is a lighter grey pill, an on switch is a light track with a dark knob, and dictation's buttons are grey. Save changes and Save as Custom stay accented. In core/, so Prism's terminal settings follow with the next core bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 23, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
…#42) (#43) Row buttons take the dropdown's look, a pressed segment is a lighter grey pill, an on switch is a light track with a dark knob, and dictation's buttons are grey. Save changes and Save as Custom stay accented. In core/, so Prism's terminal settings follow with the next core bump. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42.
Owner, 2026-09-23: settings buttons should not follow the accent colour; grey from the background with a slight contrast, the dropdown's colours; only the save buttons stay accented.
What changes (in
core/, so this is a change to Prism's terminal settings too, arriving with the core bump):ROW_BUTTON(Choose folder..., Use my user folder): the dropdown's look,--p-controlfill,--p-dividerborder,--p-textlabel.SEGMENT_ON): a lighter grey pill (--p-text16% over--p-control), text in--p-text.SWITCH_ON): track in--p-text-soft, knob in--p-bg.Prism's own settings page keeps its own copies of Switch / Segmented / the Default apps button; those get the same change in a Prism PR.
Versions: app 0.11.0 -> 0.12.0, core 0.9.0 -> 0.10.0.
Tests:
core/renderer/settings/neutralControls.test.ts: the three controls and dictation's buttons carry no accent token; SaveButton still does.accente2e: samples Choose folder, the pressed New tabs segment and an on switch, picks an accent, and asserts none moved and none wears it (replaces the check that a pressed segment wore the accent). Screenshot:.e2e-shots/settings-neutral-controls.png.npm test871/871, typecheck, lint (0 errors), full e2e 27/27 scenarios passed.Unsigned, as before.
🤖 Generated with Claude Code