This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Clean up generics #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximBazarov
approved these changes
Sep 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the single character generics to make the library a little bit more readable. This is important because most objects are public facing API, and users of the API can with a glance get context of what is needed from them.
This PR goes through the whole library and updates all generics and tries to make it more consistent throughout.
In some places, I also refactor some functions and initializers to multiple lines to make the code a little bit more readable. What would be ideal is to have a tool like Swift format run as a Github action to make all contributions more consistent