Refactor database connection fixtures and benchmark tests #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
devwdave
commented
Jan 5, 2026
devwdave
commented
- Updated PostgreSQL and MySQL connection fixtures to use NullPool for improved connection handling.
- Enhanced fixture scopes to "module" and "session" for better resource management during benchmarks.
- Simplified error messages for database connection failures.
- Refactored benchmark tests to utilize the updated Memori instance and removed unnecessary assertions.
- Consolidated benchmark result handling for consistency across different test cases.
- Updated PostgreSQL and MySQL connection fixtures to use NullPool for improved connection handling. - Enhanced fixture scopes to "module" and "session" for better resource management during benchmarks. - Simplified error messages for database connection failures. - Refactored benchmark tests to utilize the updated Memori instance and removed unnecessary assertions. - Consolidated benchmark result handling for consistency across different test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.