Block tunnel subdomain registration#950
Merged
Merged
Conversation
Ephemeral tunnel URLs (trycloudflare, ngrok, etc.) pollute the marketplace with dead origins that agents can't reach. This adds an isTunnelUrl check on both registration paths — origin-based discovery and single-endpoint — so they're rejected before any probing or DB writes happen.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTunnelUrlcheck that blocks registration for known ephemeral tunnel services (trycloudflare, ngrok, loca.lt, serveo, localhost.run, bore.pub, tunnelmole)fetchDiscoveryDocument) and single-endpoint (registerEndpoint) — covers REST API, TRPC, and UIContext: A single "py.scm" service registered 17+ ephemeral trycloudflare origins in ~2 hours, polluting the marketplace with dead URLs. 159 tunnel origins exist total (5.4% of all origins), plus 221 empty-shell origin rows with 0 resources.
Test plan
isTunnelUrl— 6 tests covering all tunnel domains, permanent domains, false-positive resistance, and invalid URLspnpm format && pnpm lint && pnpm checkall pass