fix: stop bundling unrelated origins that share a payment address#973
Closed
onchainlu wants to merge 1 commit into
Closed
fix: stop bundling unrelated origins that share a payment address#973onchainlu wants to merge 1 commit into
onchainlu wants to merge 1 commit into
Conversation
The bazaar grouping used origins[0].id as the key, so when two origins shared a payment address they were merged into one row — inflating stats and showing a spurious "+N" badge (e.g. StableMerch +1). Each origin now gets its own entry, and total_count uses distinct origin IDs instead of address count so pagination stays correct.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origins[0].idas the key when aggregating stats, so when two unrelated origins shared a payment address they were merged into one row — inflating the primary origin's stats and showing a spurious "+N" badge (e.g. StableMerch +1)total_countto use distinct origin IDs instead of address count (old value was also wrong) so pagination computes correctlyTest plan