fix: exclude deprecated resources from accepts address mapping#974
Merged
Conversation
Deprecated resources' accepts records were polluting the payTo → origin mapping used by Featured Services. This caused ghost "+1" origin counts (e.g., StableMerch showing "+1" from stablemerch.dev's deprecated records sharing stableemail.dev's payTo) and inflated transaction stats (7.86k instead of 7). Always filter deprecatedAt: null on the parent resource, not just when tags or originUrls are provided.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shafu0x
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deprecatedAt: nullonresourceRelingetAcceptsAddressesso deprecated resources never contribute to the payTo → origin mappingRoot cause
getAcceptsAddressesonly applied theresourceRelfilter whentagsororiginUrlswere provided. Without either, noresourceRelfilter was set at all, so deprecated resources' accepts records were included. The fix always setsresourceRel: { deprecatedAt: null, ... }regardless of other filters.Test plan