get path to log file explicitly #5112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedr
requested changes
Sep 19, 2025
oitel
approved these changes
Sep 19, 2025
| std::error_code ec; | ||
| if ( !std::filesystem::is_directory( fileName, ec ) ) | ||
| { | ||
| ec.clear(); |
There was a problem hiding this comment.
std::filesystem::create_directories clears ec if no errors occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log file created correctly, but the path wasn't logged. So it looks like the reasons were the
dynamic_castfailures because of symbol visibility issues between dynamic libraries on macOS inside thegetLogFileName()function.