DataClassResolver→ClassResolver; 192 tests pass

[opencode-agent]

All tests pass (192 tests). Here's a summary of the changes:

New files:

• src/main/kotlin/dev/appoutlet/some/exception/SomeInstantiationException.kt - Custom exception thrown when all constructors fail, with class name and per-constructor failure summary
• src/main/kotlin/dev/appoutlet/some/resolver/ClassResolver.kt - Renamed from DataClassResolver, now iterates over all constructors (not just primary), falls back to next constructor on failure, propagates SomeCircularReferenceException
• src/test/kotlin/dev/appoutlet/some/resolver/ClassResolverTest.kt - 16 unit tests covering: primary constructor, secondary-only constructor, fallback to secondary, empty constructor, all-fail exception, canResolve rejections (String, Int, List, Set, Map, abstract class, sealed class), canResolve acceptances, private constructor via reflection, integration test with some<T>()

Modified files:

• src/main/kotlin/dev/appoutlet/some/config/SomeConfig.kt - Updated import and references from DataClassResolver to ClassResolver
• AGENTS.md - Updated resolver registration order entry

Deleted files:

• src/main/kotlin/dev/appoutlet/some/resolver/DataClassResolver.kt

Key design decisions:

• canResolve() rejects abstract classes via Modifier.isAbstract(kClass.java.modifiers), ensuring sealed classes and interfaces are also excluded
• SomeCircularReferenceException re-thrown immediately (not caught) to preserve circular-reference diagnostics
• Private constructors can be resolved via isAccessible = true reflection — documented behavior confirmed by test
• Constructor order follows KClass.constructors iteration order (primary first, then secondary in declaration order)

Closes #46

opencode session  |  github run

[MessiasLima]

/oc add a trailing line

[opencode-agent]

Trailing newline added.

opencode session  |  github run

[opencode-agent]

The resolve method is generally well-structured, but there are a couple of improvements that would make it more explicit and robust:

1. Unsafe cast on line 111 — type.classifier as KClass<*> will throw a ClassCastException if canResolve wasn't called first. A safer pattern would be:

val kClass = type.classifier as? KClass<*>
    ?: throw SomeInstantiationException(type.classifier, listOf("Type classifier is not a KClass"))

2. Broad catch (e: Exception) — This is correct in intent (any failure means "try next constructor"), but it silently swallows truly unexpected errors (e.g., OutOfMemoryError). Consider catching more specific exceptions or at least adding an inline comment explaining the intent.

3. The SomeCircularReferenceException re-throw pattern is correct and necessary — it's the standard way to exclude specific exceptions from a broad catch. This is clear as-is.

Overall the logic is sound. The biggest improvement would be replacing the unchecked cast with an explicit error — it would make the contract self-enforcing rather than relying on canResolve being called first. Want me to make these changes?

opencode session  |  github run