-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Wire AndroidTypeResolverProvider and ServiceLoader Tests #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MessiasLima
merged 6 commits into
main
from
android-resolver-provider-wiring-12906260935489321471
Jun 22, 2026
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41bb3cc
Wire AndroidTypeResolverProvider and add ServiceLoader integration tests
google-labs-jules[bot] 20eeef1
Wire AndroidTypeResolverProvider and add ServiceLoader integration tests
google-labs-jules[bot] 559cad8
simplify interface names
MessiasLima 830970d
autoservice
MessiasLima 7237fc8
manual service definition
MessiasLima 8cffd74
fix: manual setup
MessiasLima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
android/src/main/resources/META-INF/services/dev.appoutlet.some.core.TypeResolverProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| dev.appoutlet.some.android.AndroidTypeResolverProvider |
21 changes: 21 additions & 0 deletions
21
android/src/test/java/dev/appoutlet/some/android/AndroidServiceLoaderTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package dev.appoutlet.some.android | ||
|
|
||
| import dev.appoutlet.some.some | ||
| import dev.appoutlet.some.someSetup | ||
| import org.junit.Assert.assertTrue | ||
| import org.junit.Test | ||
|
|
||
| class AndroidServiceLoaderTest { | ||
| @Test | ||
| fun `AndroidTypeResolverProvider is discovered and does not break the chain`() { | ||
| val some = someSetup { } | ||
| val result: String = some.some() | ||
| assertTrue("Generated string should not be empty", result.isNotEmpty()) | ||
| } | ||
|
|
||
| @Test | ||
| fun `top-level some also works with AndroidTypeResolverProvider`() { | ||
| val result: String = some() | ||
| assertTrue("Generated string should not be empty", result.isNotEmpty()) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.