-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git migration package #74
Conversation
Issues:jules revision r1710 mapped to um10.2; but looks like the commit is not in the git log! { "um10.2": 1710 } Fix:thanks @jennyhickson for the detective work
{ "um10.2": 1709 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've added a couple of suggestions.
Results of testingInteractive test of the script without a test of the update functionality. The elapsed time was 02:49:13.
|
Thank you @t00sa. The parallel version committed in ecb6101 reduced the runtime by half on Azure SPICE VDI.
|
I've done a complete refactor of the script with following changes:
and additional options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very elegant refactor. Happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having thoroughly explained each function in the shell script with Copilot my only suggestion is adding comments if the script will be reused and modified in the future. Otherwise, it appears ready for merging as an initial (and elegant) implementation of the SVN to Git migration. Great job Yash :) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion on the wording for shumlib
done. Co-authored-by: James Bruten <[email protected]>
To keep a record of things we plan to do for git migration, I've added a checklist list and how we intend to migrate the repositories from MOSRS to GitHub.