Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for suite_report extract paths #75

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

james-bruten-mo
Copy link
Contributor

@james-bruten-mo james-bruten-mo commented Apr 1, 2025

The physics fork updated the location of the jules and socrates extract paths, so checks in suite report for lfric testing stopped working. This PR fixes that.

I've tested this by running on a Jules rose-stem run with changes to extracted files and made sure lfric testing is requested

@james-bruten-mo james-bruten-mo requested a review from a team as a code owner April 1, 2025 14:44
@yaswant yaswant removed the request for review from a team April 1, 2025 15:18
Copy link
Contributor

@jennyhickson jennyhickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a sensible way to merge together output from multiple files

Copy link
Contributor

@Pierre-siddall Pierre-siddall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like solid changes I'm happy to go ahead with this merge.

@Pierre-siddall Pierre-siddall self-requested a review April 7, 2025 10:10
@Pierre-siddall Pierre-siddall merged commit e7eae9e into main Apr 7, 2025
16 checks passed
@Pierre-siddall Pierre-siddall deleted the fix_lfric_extract_files branch April 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants