Skip to content

Post-processing: Make python library installable with pip#236

Merged
Ed Hone (EdHone) merged 8 commits intoMetOffice:mainfrom
EdHone:py-vernier-pip
Mar 25, 2026
Merged

Post-processing: Make python library installable with pip#236
Ed Hone (EdHone) merged 8 commits intoMetOffice:mainfrom
EdHone:py-vernier-pip

Conversation

@EdHone
Copy link
Collaborator

@EdHone Ed Hone (EdHone) commented Mar 23, 2026

Description

Makes the post-processing tools installable with pip. Some repo restructuring was needed to make CLI tools discoverable by setuptools.

To test, try installing package with pip inside a venv:

python -m venv test_vernier_install
source ./test_vernier_install/bin/activate
pip install post-processing/

and try running the unit tests and CLI:

python -m unittest discover post-processing
summarise-vernier post-processing/vernier/tools/vernier-output-example-collated

Linked issues

Closes #233

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • New tests have been added
  • Tests have been modified to accommodate this change

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes, for both debug and optimised builds

@github-actions github-actions bot added cla-required The CLA has not yet been signed by the author of this PR - added by GA cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Mar 23, 2026
@EdHone Ed Hone (EdHone) changed the title Py vernier pip Post-processing: Make python library installable with pip Mar 23, 2026
@EdHone Ed Hone (EdHone) self-assigned this Mar 24, 2026
@github-actions github-actions bot added cla-modified The CLA has been modified as part of this PR - added by GA and removed cla-signed The CLA has been signed as part of this PR - added by GA labels Mar 25, 2026
@EdHone Ed Hone (EdHone) marked this pull request as ready for review March 25, 2026 11:06
@github-actions github-actions bot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Mar 25, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D

@t00sa
Copy link
Collaborator

Copying my reply here for posterity: it all looks good to me. I suspect the easiest way to manage the installation with spack might be to continue with the existing core vernier package and to introduce a new py-vernier-tools package to install the user-facing commands.

@EdHone Ed Hone (EdHone) merged commit 453c093 into MetOffice:main Mar 25, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation of post-processing tools

3 participants