Skip to content

Add initial QA checks to CI/CD pipeline.#12

Open
Pierre-siddall wants to merge 2 commits intoMetOffice:mainfrom
Pierre-siddall:add-inital-checks
Open

Add initial QA checks to CI/CD pipeline.#12
Pierre-siddall wants to merge 2 commits intoMetOffice:mainfrom
Pierre-siddall:add-inital-checks

Conversation

@Pierre-siddall
Copy link

@Pierre-siddall Pierre-siddall commented Mar 11, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @cameronbateman-mo

Similarly to MetOffice/lfric_apps#200 and MetOffice/lfric_core#258 ukca needs some initial code quality checks to be performed. With the move to fortitude to lint fortran this PR uses the growss repository to invoke a reusable workflow which lints a predefined set of rules outlined in a fortitude.toml file.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

closes #2

trac.log

Test Suite Results - um - casim-fortitude-implementation-tests/run2

Suite Information

Item Value
Suite Name casim-fortitude-implementation-tests/run2
Suite User pierre.siddall
Workflow Start 2026-03-13T15:26:38
Groups Run developer
Dependency Reference Main Like
casim Pierre-siddall/casim@add-inital-checks False
jules MetOffice/[email protected] True
moci MetOffice/[email protected] True
mule MetOffice/[email protected] True
shumlib MetOffice/[email protected] True
socrates MetOffice/[email protected] True
SimSys_Scripts MetOffice/[email protected] True
ukca Pierre-siddall/ukca@fortitude-fixes False
um Pierre-siddall/um@f32cbf4 True
um_aux MetOffice/[email protected] True
um_meta MetOffice/[email protected] True

Approvals

Code Owners

  • No UM Code Owners Required

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 881

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@Pierre-siddall Pierre-siddall self-assigned this Mar 11, 2026
@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Mar 11, 2026
@Pierre-siddall Pierre-siddall marked this pull request as ready for review March 13, 2026 15:52
@Pierre-siddall
Copy link
Author

Currently waiting on a trac.log to be generated I'll append to the ticket before review.

@Pierre-siddall Pierre-siddall marked this pull request as draft March 16, 2026 11:24
@Pierre-siddall Pierre-siddall marked this pull request as ready for review March 16, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Action to perform initial quality checks

1 participant