Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of what we will have learnt/done by the end of the lesson #94

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

astroDimitrios
Copy link
Member

Fixes #64

List added in episode 1 and swap out the diagram in then end card as it is incorrect for Squashing and Merging.
#64 suggested adding the diagram to the start as well but it is too much I think for the intro and a list is simpler.

… in episode 1 and swap out the diagram in then end card as it is incorrect for Squashing and Merging
Copy link

@mo-tgeddes mo-tgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) . Just a couple of comments about the list in the beginning.

episodes/01-basics.md Outdated Show resolved Hide resolved
episodes/01-basics.md Outdated Show resolved Hide resolved
episodes/01-basics.md Outdated Show resolved Hide resolved
@astroDimitrios astroDimitrios merged commit 4a5059f into MetOffice:main Dec 18, 2024
1 check passed
@astroDimitrios astroDimitrios deleted the 64_workflow_diag branch December 18, 2024 15:01
github-actions bot pushed a commit to astroDimitrios/git-novice that referenced this pull request Dec 18, 2024
Auto-generated via `{sandpaper}`
Source  : 4a5059f
Branch  : main
Author  : Dimitrios Theodorakis <[email protected]>
Time    : 2024-12-18 15:01:40 +0000
Message : MetOffice#94 Add a list of what we will have learnt/done by the end of the lesson

* Add a list of what we will have learnt/done by the end of the episode in episode 1 and swap out the diagram in then end card as it is incorrect for Squashing and Merging

* Respond to review comments
github-actions bot pushed a commit to astroDimitrios/git-novice that referenced this pull request Dec 18, 2024
Auto-generated via `{sandpaper}`
Source  : 061f97f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-18 15:02:44 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 4a5059f
Branch  : main
Author  : Dimitrios Theodorakis <[email protected]>
Time    : 2024-12-18 15:01:40 +0000
Message : MetOffice#94 Add a list of what we will have learnt/done by the end of the lesson

* Add a list of what we will have learnt/done by the end of the episode in episode 1 and swap out the diagram in then end card as it is incorrect for Squashing and Merging

* Respond to review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in a diagram showing the workflow we will follow at the start and the end
2 participants