Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 6 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@
**/adjoint_tests @DrTVockerodtMO # @mo-joshuacolclough
**/gravity_wave @thomasmelvin # @cjohnson-pi
**/gungho_model @thomasmelvin # @BShipway
**/jedi_lfric_tests @ss421 @matthewrmshin # @DavidSimonin
**/jedi_lfric_tests @ss421 @matthewrmshin @MetOffice/r2o-systems
**/jules @iboutle # @MetOfficessdtesam
**/lfric2lfric @mo-lottieturner # @mike-hobson
**/lfricinputs @mo-lottieturner # @mike-hobson
**/lfric_atm @iboutle # @BShipway
**/lfric_coupled @HengistPodd # @BShipway
**/lfricinputs @mo-lottieturner # @mike-hobson
**/linear_model @cjohnson-pi @ss421 @matthewrmshin # @tommbendall # Also notifiy jedi team about linear changes.
**/linear_model @cjohnson-pi @MetOffice/r2o-systems # @tommbendall # Also notifiy jedi team about linear changes.
**/name_transport @jameskent-metoffice # @tommbendall
**/ngarch @christophermaynard # @jcsmeto
**/shallow_water @jameskent-metoffice # @atb1995
Expand All @@ -22,7 +23,7 @@

# Science
**/adjoint @DrTVockerodtMO # @mo-joshuacolclough
**/linear @cjohnson-pi @ss421 @matthewrmshin # @tommbendall # Also notifiy jedi team about linear changes.
**/linear @cjohnson-pi @MetOffice/r2o-systems # @tommbendall # Also notifiy jedi team about linear changes.
science/shared/source/constants/ @iboutle # @BShipway

**/gungho @thomasmelvin # @iboutle
Expand Down Expand Up @@ -53,7 +54,7 @@ science/physics_schemes/**/stochastic_physics @wjtmo # @a

# Interfaces
**/coupled_interface @mike-hobson # @harry-shepherd
**/jedi_lfric_interface @ss421 @matthewrmshin # @DavidSimonin
**/jedi_lfric_interface @ss421 @matthewrmshin @MetOffice/r2o-systems
**/jules_interface @iboutle # @MetOfficessdteam
**/jules_interface/rose-meta @maggiehendry
**/physics_schemes_interface @iboutle # @MetOfficessdteam
Expand All @@ -70,6 +71,7 @@ rose-stem/apps # Mostly updated by macros, no codeowner
build/ @MetOffice/ssdteam @hiker
**/*Makefile @MatthewHambley @hiker
**/*.mk @MatthewHambley @hiker
**/optimisation @christophermaynard # HPC Optimisation Team

# Other areas
documentation # @MetOffice/ssdteam
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
Thanks for taking the time to fill out this bug report! _If you are planning
to work on this issue, then please assign yourself to it._
- type: dropdown
id: version
attributes:
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/custom_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ body:
- type: markdown
attributes:
value: |
Thanks for taking the time to help improve LFRic Apps.
Thanks for taking the time to help improve LFRic Apps. _If you are planning
to work on this issue, then please assign yourself to it._
- type: input
id: linked-issues
attributes:
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ body:
- type: markdown
attributes:
value: |
Thanks for taking the time to help improve the LFRic Apps documentation.
Thanks for taking the time to help improve the LFRic Apps documentation.
_If you are planning to work on this issue, then please assign yourself to it._
- type: input
id: linked-issues
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) -->

## PSyclone Approval

- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](toolscollabdevteam@metoffice.gov.uk)
- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](mailto:ToolsCollabDevTeam@metoffice.gov.uk)

# Sci/Tech Review

Expand Down
4 changes: 4 additions & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
| jennyhickson | Jenny Hickson | Met Office | 2025-12-10 |
| mike-hobson | Mike Hobson | Met Office | 2025-12-17 |
| mo-marqh | mark Hedley | Met Office | 2025-12-11 |
| mo-rickywong | Ricky Wong | Met Office | 2026-24-02 |
| yaswant | Yaswant Pradhan | Met Office | 2025-12-16 |
| oakleybrunt | Oakley Brunt | Met Office | 2025-12-19 |
| harry-shepherd | Harry Shepherd | Met Office | 2026-01-08 |
Expand All @@ -31,3 +32,6 @@
| ukmo-juan-castillo | Juan M. Castillo | Met Office | 2026-01-23 |
| Adrian-Lock | Adrian Lock | Met Office | 2026-01-09 |
| thomasmelvin | Thomas Melvin | Met Office | 2026-01-15 |
| tinyendian | Wolfgang Hayek | Earth Sciences New Zealand | 2026-02-02 |
| DanStoneMO | Daniel Stone | Met Office | 2026-02-26 |
| ericaneininger | Erica Neininger | Met Office | 2026-03-02 |
30 changes: 23 additions & 7 deletions applications/adjoint_tests/example/configuration.nml
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ stretching_method='smooth',
ancil_directory='/data/users/lfricadmin/data/ancils/basic-gal/yak/C12',
checkpoint_stem_name='',
diag_stem_name='diagGungho',
ls_directory='/data/users/lfricadmin/data/tangent-linear/Ticket354',
ls_filename='final_ls',
ls_directory='/data/users/lfricadmin/data/tangent-linear/PullRequest182'
ls_filename='final_ls_with_land',
orography_mean_ancil_path='orography/gmted_ramp2/qrparm.orog',
start_dump_directory='/data/users/lfricadmin/data/tangent-linear/Ticket354',
start_dump_filename='final_pert',
Expand Down Expand Up @@ -220,13 +220,24 @@ write_fluxes=.false.,
write_minmax_tseries=.false.,
/
&linear
fixed_ls=.true.
l_stabilise_bl=.true.,
fixed_ls=.true.,
l_stabilise_bl=.false.,
ls_read_w2h=.false.,
max_bl_stabilisation=0.75,
n_bl_levels_to_stabilise=15,
pert_option='file',
transport_efficiency=.true.
transport_efficiency=.true.,
/
&linear_physics
blevs_m=15,
e_folding_levs_m=10,
l_0_m=80.0,
l_boundary_layer=.true.,
log_layer=2,
u_land_m=0.4,
u_sea_m=0.4,
z_land_m=0.05,
z_sea_m=0.0005,
/
&logging
log_to_rank_zero_only=.false.,
Expand Down Expand Up @@ -275,11 +286,16 @@ panel_yproc=1,
partitioner='cubedsphere',
/
&physics
configure_segments=.false.,
bl_segment=0,
configure_segments=.true.,
conv_gr_segment=16,
gw_segment=0,
limit_drag_incs=.false.,
ls_ppn_segment=0,
sample_physics_scalars=.true.,
sample_physics_winds=.true.,
sample_physics_winds_correction=.false.,
ussp_segment=0,
/
&planet
cp=1005.0,
Expand Down Expand Up @@ -355,7 +371,7 @@ tau_u=0.55,
/
&transport
adjust_theta=.false.,
adjust_tracer_equation=.false.
adjust_tracer_equation=.false.,
adjust_vhv_wind=.false.,
ageofair_reset_level=10,
broken_w2_projection=.false.,
Expand Down
6 changes: 6 additions & 0 deletions applications/adjoint_tests/example/iodef.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@
<axis axis_ref="vert_axis_half_levels"/>
<axis axis_ref="ls_axis"/>
</grid>
<grid id="one_level_face_time_grid">
<domain domain_ref="face"/>
<axis axis_ref="1"/>
<axis axis_ref="ls_axis"/>
</grid>
</grid_definition>

<field_definition prec="8" >
Expand Down Expand Up @@ -322,6 +327,7 @@
<field id="ls_u_in_w3_data" name="u_in_w3" long_name="NS wind" unit="m s-1" grid_ref="half_level_face_time_grid" operation="once"/>
<field id="ls_v_in_w3_data" name="v_in_w3" long_name="EW wind" unit="m s-1" grid_ref="half_level_face_time_grid" operation="once"/>
<field id="ls_w_in_wth_data" name="w_in_wth" long_name="Upward wind" unit="m s-1" grid_ref="full_level_face_time_grid" operation="once"/>
<field id="ls_land_fraction_data" name="land_area_fraction" long_name="land_area_fraction" unit="1" grid_ref="one_level_face_time_grid" operation="once" />
</file>

</file_definition>
Expand Down
Loading