Skip to content

Extract external metadata#279

Open
james-bruten-mo wants to merge 41 commits intoMetOffice:mainfrom
james-bruten-mo:lfric_jules_metadata
Open

Extract external metadata#279
james-bruten-mo wants to merge 41 commits intoMetOffice:mainfrom
james-bruten-mo:lfric_jules_metadata

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Feb 23, 2026

PR Summary

Sci/Tech Reviewer: @MatthewHambley
Code Reviewer: @t00sa

jules-shared is currently duplicated between LFRic Apps and Jules, so that it's available to the lfric build system configuration step. Ideally we'd remove this duplication. This PR, along with MetOffice/lfric_core#285, will edit the code extraction and configuration steps so that external metadata can be used. Then a follow up Apps and Jules PR will remove the duplicated metadata.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - external_meta_apps/run2

Suite Information

Item Value
Suite Name external_meta_apps/run2
Suite User james.bruten
Workflow Start 2026-03-16T14:09:17
Groups Run developer
Dependency Reference Main Like
casim MetOffice/[email protected] True
jules MetOffice/[email protected] True
lfric_apps james-bruten-mo/lfric_apps@lfric_jules_metadata False
lfric_core james-bruten-mo/lfric_core@lfric_jules_metadata True
moci MetOffice/[email protected] True
SimSys_Scripts MetOffice/[email protected] True
socrates MetOffice/[email protected] True
socrates-spectral MetOffice/[email protected] True
ukca MetOffice/[email protected] True

Task Information

✅ succeeded tasks - 1164

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

james-bruten-mo and others added 30 commits January 19, 2026 15:57
Co-authored-by: Sam Clarke-Green <[email protected]>
 All conflicts fixed but you are still merging.
@github-actions github-actions bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Mar 10, 2026
@github-actions github-actions bot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Mar 10, 2026
@james-bruten-mo james-bruten-mo changed the title Lfric jules metadata Extract external metadata Mar 16, 2026
@james-bruten-mo james-bruten-mo marked this pull request as ready for review March 16, 2026 14:57
@james-bruten-mo james-bruten-mo requested review from jennyhickson and removed request for a team and jennyhickson March 16, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant