Open
Conversation
…mo/lfric_apps into improve_local_builds
Co-authored-by: Matthew Hambley <[email protected]>
…mo/lfric_apps into improve_local_builds
…mo/lfric_apps into improve_local_builds
Co-authored-by: Sam Clarke-Green <[email protected]>
All conflicts fixed but you are still merging.
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @MatthewHambley
Code Reviewer: @t00sa
jules-shared is currently duplicated between LFRic Apps and Jules, so that it's available to the lfric build system configuration step. Ideally we'd remove this duplication. This PR, along with MetOffice/lfric_core#285, will edit the code extraction and configuration steps so that external metadata can be used. Then a follow up Apps and Jules PR will remove the duplicated metadata.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - external_meta_apps/run2
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review