Skip to content

Remove finalise method from adjoint lookup tables #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DrTVockerodtMO wants to merge 7 commits into from
Closed

Remove finalise method from adjoint lookup tables #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a493cb
Added clearing of member integer fields
DrTVockerodtMO Mar 3, 2026
d8069be
No need for the lookup table finaliser routine as the default destruc…
DrTVockerodtMO Mar 3, 2026
d3557ae
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 5, 2026
6ed3f65
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 5, 2026
3231554
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 6, 2026
213740a
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 10, 2026
28bb2be
Merge branch 'main' into lu_cache_memory_leak_fix
DrTVockerodtMO Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions science/adjoint/source/algorithm/lookup/adj_lookup_table_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ module adj_lookup_table_mod
procedure, public :: get_nsets_max
procedure, public :: get_nindices
procedure, public :: get_ndata
procedure, public :: finalise => adj_lookup_table_finaliser
end type adj_lookup_table_type

contains
Expand Down Expand Up @@ -231,18 +230,4 @@ module adj_lookup_table_mod

end function get_ndata

!=============================================================================
!> @brief Destructor.
!> @param [in,out] self Lookup table
subroutine adj_lookup_table_finaliser( self )

implicit none

! Arguments
class(adj_lookup_table_type), intent(inout) :: self

! Pass

end subroutine adj_lookup_table_finaliser

end module adj_lookup_table_mod
10 changes: 1 addition & 9 deletions science/adjoint/source/algorithm/lookup/solver/adj_solver_lookup_cache_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,7 @@ module adj_solver_lookup_cache_mod
! Arguments
class(adj_solver_lookup_cache_type), intent(inout) :: self

! Internal variables
integer(kind=i_def) :: level

if (self%is_initialised) then
do level = 1, self%multigrid_levels + 1
call self%lookup_apply_hho(level)%finalise()
end do
if (allocated(self%lookup_apply_hho)) deallocate(self%lookup_apply_hho)
end if
if (allocated(self%lookup_apply_hho)) deallocate(self%lookup_apply_hho)

end subroutine adj_solver_lookup_cache_final

Expand Down
17 changes: 2 additions & 15 deletions science/adjoint/source/algorithm/lookup/transport/adj_trans_lookup_cache_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,21 +394,8 @@ module adj_trans_lookup_cache_mod
! Arguments
class(adj_trans_lookup_cache_type), intent(inout) :: self

! Internal variables
integer(kind=i_def) :: fspace_index

if (self%is_initialised) then
call self%lookup_poly1d%finalise()
do fspace_index = 1_i_def, self%n_fs_poly2d
call self%lookup_poly2d(fspace_index)%finalise()
end do
call self%lookup_poly_adv_upd%finalise()
do fspace_index = 1_i_def, self%n_fs_w3h_adv_upd
call self%lookup_w3h_adv_upd(fspace_index)%finalise()
end do
if (allocated(self%lookup_poly2d)) deallocate(self%lookup_poly2d)
if (allocated(self%lookup_w3h_adv_upd)) deallocate(self%lookup_w3h_adv_upd)
end if
if (allocated(self%lookup_poly2d)) deallocate(self%lookup_poly2d)
if (allocated(self%lookup_w3h_adv_upd)) deallocate(self%lookup_w3h_adv_upd)

end subroutine adj_trans_lookup_cache_final

Expand Down
Loading