Open
Conversation
ericaneininger
approved these changes
Mar 10, 2026
Contributor
ericaneininger
left a comment
There was a problem hiding this comment.
Code owner approval for science/adjoint/build/* on behalf of the SSD team.
mo-joshuacolclough
approved these changes
Mar 13, 2026
mo-joshuacolclough
left a comment
There was a problem hiding this comment.
Passes Sci/Tech review. Thank you @DrTVockerodtMO, good to see these patches starting to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @mo-joshuacolclough
Code Reviewer: @mo-marqh
Removed the PSyAd patches for the algebra adjoints. Unstaged the algebra kernels and test algorithms from being built via PSyAd. Added the algebra adjoint kernels and test algorithms as source code in
adjointandadjoint_testsrespectively. I have also taken the liberty to make them faster to run by simplifying a lot of the PSyAdisms.N.B.: Unit testing adjoint kernels is a bit different to usual kernels. There are no pFUnit tests for these kernels because the unit test for them involves testing against the tangent linear source code (i.e.: testing against kernels/algorithms in
lfric_core,gungho,linear, etc.). These have been committed onto the branch.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - wololo_psyad_algebra/run2
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review