Skip to content

Remove algebra PSyAd code#341

Open
DrTVockerodtMO wants to merge 6 commits intoMetOffice:mainfrom
DrTVockerodtMO:convert_psyad_algebra
Open

Remove algebra PSyAd code#341
DrTVockerodtMO wants to merge 6 commits intoMetOffice:mainfrom
DrTVockerodtMO:convert_psyad_algebra

Conversation

@DrTVockerodtMO
Copy link
Contributor

@DrTVockerodtMO DrTVockerodtMO commented Mar 5, 2026

PR Summary

Sci/Tech Reviewer: @mo-joshuacolclough
Code Reviewer: @mo-marqh

Removed the PSyAd patches for the algebra adjoints. Unstaged the algebra kernels and test algorithms from being built via PSyAd. Added the algebra adjoint kernels and test algorithms as source code in adjoint and adjoint_tests respectively. I have also taken the liberty to make them faster to run by simplifying a lot of the PSyAdisms.

N.B.: Unit testing adjoint kernels is a bit different to usual kernels. There are no pFUnit tests for these kernels because the unit test for them involves testing against the tangent linear source code (i.e.: testing against kernels/algorithms in lfric_core, gungho, linear, etc.). These have been committed onto the branch.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - wololo_psyad_algebra/run2

Suite Information

Item Value
Suite Name wololo_psyad_algebra/run2
Suite User terence.vockerodt
Workflow Start 2026-03-05T19:36:11
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.1 True
jules MetOffice/jules@2026.03.1 True
lfric_apps DrTVockerodtMO/lfric_apps@convert_psyad_algebra False
lfric_core MetOffice/lfric_core@2026.03.1 True
moci MetOffice/moci@2026.03.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True
socrates MetOffice/socrates@2026.03.1 True
socrates-spectral MetOffice/socrates-spectral@2026.03.1 True
ukca MetOffice/ukca@2026.03.1 True

Task Information

✅ succeeded tasks - 1164

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@DrTVockerodtMO DrTVockerodtMO self-assigned this Mar 5, 2026
@DrTVockerodtMO DrTVockerodtMO requested review from a team, MatthewHambley and hiker as code owners March 5, 2026 17:20
@DrTVockerodtMO DrTVockerodtMO requested review from Pierre-siddall and removed request for a team March 5, 2026 17:20
@DrTVockerodtMO DrTVockerodtMO added this to the Summer 2026 milestone Mar 5, 2026
@Pierre-siddall Pierre-siddall requested review from a team, Pierre-siddall and ericaneininger and removed request for a team, Pierre-siddall and ericaneininger March 9, 2026 13:15
@mo-marqh mo-marqh self-requested a review March 9, 2026 15:25
Copy link
Contributor

@ericaneininger ericaneininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval for science/adjoint/build/* on behalf of the SSD team.

@jennyhickson jennyhickson removed the request for review from Pierre-siddall March 10, 2026 09:47
Copy link

@mo-joshuacolclough mo-joshuacolclough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes Sci/Tech review. Thank you @DrTVockerodtMO, good to see these patches starting to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert algebra PSyAd kernels and algorithms into source code

3 participants