Adding fortitude

[mo-lucy-gordon]

PR Summary

Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @Pierre-siddall

This adds the fortitude linter to the test suite and enables one rule to run to demonstrate basic functionality. Subsequent branches will add more rules and testing. The script that launches fortitude is on the SimSys_Scripts repo.

Blocked by and linked to: MetOffice/SimSys_Scripts#211

Associated with MetOffice/lfric_apps#150

This addition will mean Fortitude will run when the "scripts", "developer", "all" or "fortitude_linter" group itself is run with the Cylc test suite.

The rule added here can be referenced Fortitude documentation website here: https://fortitude.readthedocs.io/en/stable/rules/use-all/

For reference, these are some example outputs and errors from when fortitude runs:

• No errors, run with group=fortitude_linter
  https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_ia_fort%2Frun3&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.out

• Lint errors, run with group=fortitude_linter:
  https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_ia_fort%2Frun4&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err

• Non-lint errors, run with group=fortitude_linter:
  https://cylchub/services/cylc-review/view/lucy.gordon?&suite=lcore_ia_fort%2Frun5&no_fuzzy_time=0&path=log/job/1/fortitude_linter/01/job.err

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's
  style guidelines
• Comments have been included that aid understanding and enhance the
  readability of the code
• My changes generate no new warnings

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite
  using this branch
• If any tests fail (rose-stem or CI) the reason is understood and
  acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system
  tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource
  and have been allocated to an appropriate testing group (i.e. the
  developer tests are for jobs which use a small amount of compute resource
  and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - lcore_ia_fort_tu1/run1

Suite Information

Item	Value
Suite Name	lcore_ia_fort_tu1/run1
Suite User	lucy.gordon
Workflow Start	2026-03-11T18:32:28
Groups Run	scripts

Dependency	Reference	Main Like
lfric_core	mo-lucy-gordon/lfric_core@adding_fortitude	False
SimSys_Scripts	MetOffice/SimSys_Scripts@2025.12.1	True

Task Information

✅ succeeded tasks - 10

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable
  performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance
  of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
  Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
  Simulation Systems AI policy
  (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and
  confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel
  interface, optimisation scripts, LFRic data structure code) then please
  contact the
  tooscollabdevteam@metoffice.gov.uk

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[mo-lucy-gordon]

I just spotted a print message I forgot to correct the formatting for so added one more commit to fix it.

[james-bruten-mo]

The comments in the similar Apps ticket are generally relevant here too!

[mo-lucy-gordon]

I have addressed the code review comments (see MetOffice/lfric_apps#150 for comments) and modified the launcher script so that it is the same for Lfric Apps and Core, so it could be moved to SimSys_Scripts in a follow up ticket. Or I could do that PR first and modify this one to remove it?

MetOffice/SimSys_Scripts#211

[mo-lucy-gordon]

I have moved the launcher script to SimSys Scripts and deleted from this repo, added a command to copy it to the repo's run bin directory

[james-bruten-mo]

A slight tweak needed here, but otherwise the changes are all good. I think you've also got a badly resolved merge conflict in the CONTRIBUTORS file

[james-bruten-mo]

Sorry Lucy - there's a difference in the setup of Core and Apps in the extract step, due to partner sites having additional requirements for apps.
Here, could you remove this rose App and move the cp command to rose-stem/templates/runtime/generat_runtime_control.cylc please