Open
Conversation
james-bruten-mo
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @andrewcoughtrie
This PR enables the IO_demo app to checkpoint itself. This is achieved by the addition of a small new module (~100 lines of code) which creates a new checkpointing context, creates the definitions for the relevant checkpoint/restart files and adds the context to the clock event loop.
Where possible, this should be the template used to set up checkpointing for all LFRic applications.
I have also added some nrun-vs-crun tests to the IO_demo rose-stem developer tests which pass, demonstrating the new functionality.
I also moved some things around in the
lfric_xios_context_mod, namely the callipers which were confusingly outside of the if statement that controlled whether the measured code would be run.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric_core-287-io_demo-cruns/run9
Suite Information
Task Information
✅ succeeded tasks - 73
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review