Add CMIP7 future scenario solar variability files#6
Open
mo-jmanners wants to merge 1 commit intoMetOffice:mainfrom
Open
Add CMIP7 future scenario solar variability files#6mo-jmanners wants to merge 1 commit intoMetOffice:mainfrom
mo-jmanners wants to merge 1 commit intoMetOffice:mainfrom
Conversation
Open
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @martinbandrews
Code Reviewer: @r-sharp
Spectral variability files are added for the CMIP7 future solar scenario. The added files are documented in the README file for the directory. The new spectral_var 'scenario' files contain the historical data from 1850-2023 followed by the future scenario data from 2024-2299. They historical data in these files is identical to the 'ref' spectral_var files and can therefore be used in-place of those files with bit-comparable results.
An additional PI control file is added with the year changed from 1850 to 1. This will allow control runs to start from any year after year 1 using the mean PI control solar spectrum.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
No shared files have been modified.
If shared files have been modified, I have run the UM and LFRic Apps rose
stem suites
If any tests fail (rose-stem or CI) the reason is understood and
acceptable (eg. kgo changes)
I have added tests to cover new functionality as appropriate (eg. system
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review