Remove state for deleted transactions

Author: matthewwalsh0

packages/transaction-pay-controller/src/utils/transaction.test.ts

@@ -157,6 +157,32 @@ describe('Transaction Utils', () => {
         );
       },
     );
+
+    it('removes state if transaction is deleted', () => {
+      const removeTransactionDataMock = jest.fn();
+
+      pollTransactionChanges(messenger, noop, removeTransactionDataMock);
+
+      publish(
+        'TransactionController:stateChange',
+        {
+          transactions: [TRANSACTION_META_MOCK],
+        } as TransactionControllerState,
+        [],
+      );
+
+      publish(
+        'TransactionController:stateChange',
+        {
+          transactions: [] as TransactionMeta[],
+        } as TransactionControllerState,
+        [],
+      );
+
+      expect(removeTransactionDataMock).toHaveBeenCalledWith(
+        TRANSACTION_ID_MOCK,
+      );
+    });
   });
 
   describe('updateTransaction', () => {

packages/transaction-pay-controller/src/utils/transaction.ts

@@ -85,7 +85,11 @@ export function pollTransactionChanges(
         );
       });
 
-      finalizedTransactions.forEach((tx) =>
+      const deletedTransactions = (previousTransactions ?? []).filter(
+        (prevTx) => !transactions.find((tx) => tx.id === prevTx.id),
+      );
+
+      [...finalizedTransactions, ...deletedTransactions].forEach((tx) =>
         onTransactionFinalized(tx, removeTransactionData),
       );