-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: GH action to remind developers to add release notes in CHANGELOG.md #5575
base: main
Are you sure you want to change the base?
Conversation
bdc6f9e
to
bb9d0bd
Compare
3e19b80
to
0c5b244
Compare
scripts/changelog-check.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is intended to be moved to the github-tools repository later.
package.json
Outdated
@@ -18,6 +18,7 @@ | |||
"build:only-clean": "rimraf -g 'packages/*/dist'", | |||
"build:docs": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run build:docs", | |||
"build:types": "tsc --build tsconfig.build.json --verbose", | |||
"changelog:check": "ts-node scripts/changelog-check.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is intended to be moved to the github-tools repository later.
4929ce6
to
f7d3f7c
Compare
2f9d326
to
7646392
Compare
7646392
to
291a919
Compare
@@ -1 +1,2 @@ | |||
export * from './EnsController'; | |||
export type TestType = 'test'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dummy change that should trigger the workflow
197aebe
to
59e5e47
Compare
Explanation
This PR introduces a new CI workflow that enforces the inclusion of a CHANGELOG entry for any changes made by developers. It supports both single-package repositories and monorepos using Yarn workspaces.
The shared workflow has been structured for easy migration to the github-tools repository in the future.
Testing flow:
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3678
References
Changelog
Checklist