Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache incoming transaction timestamps #5582

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Apr 2, 2025

Explanation

If queryEntireHistory is false, query incoming transactions from the last 24 hours.

If no cursor is returned, cache the startTimestamp and use that in subsequent queries until a cursor is available.

References

Fixes #30902

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-888fa154",
  "@metamask-previews/address-book-controller": "6.0.3-preview-888fa154",
  "@metamask-previews/announcement-controller": "7.0.3-preview-888fa154",
  "@metamask-previews/approval-controller": "7.1.3-preview-888fa154",
  "@metamask-previews/assets-controllers": "55.0.1-preview-888fa154",
  "@metamask-previews/base-controller": "8.0.0-preview-888fa154",
  "@metamask-previews/bridge-controller": "11.0.0-preview-888fa154",
  "@metamask-previews/bridge-status-controller": "10.0.0-preview-888fa154",
  "@metamask-previews/build-utils": "3.0.3-preview-888fa154",
  "@metamask-previews/chain-agnostic-permission": "0.3.0-preview-888fa154",
  "@metamask-previews/composable-controller": "11.0.0-preview-888fa154",
  "@metamask-previews/controller-utils": "11.6.0-preview-888fa154",
  "@metamask-previews/earn-controller": "0.10.0-preview-888fa154",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-888fa154",
  "@metamask-previews/ens-controller": "16.0.0-preview-888fa154",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-888fa154",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-888fa154",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-888fa154",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-888fa154",
  "@metamask-previews/keyring-controller": "21.0.1-preview-888fa154",
  "@metamask-previews/logging-controller": "6.0.4-preview-888fa154",
  "@metamask-previews/message-manager": "12.0.1-preview-888fa154",
  "@metamask-previews/multichain": "4.0.0-preview-888fa154",
  "@metamask-previews/multichain-api-middleware": "0.1.1-preview-888fa154",
  "@metamask-previews/multichain-network-controller": "0.3.0-preview-888fa154",
  "@metamask-previews/multichain-transactions-controller": "0.8.0-preview-888fa154",
  "@metamask-previews/name-controller": "8.0.3-preview-888fa154",
  "@metamask-previews/network-controller": "23.1.0-preview-888fa154",
  "@metamask-previews/notification-services-controller": "5.0.1-preview-888fa154",
  "@metamask-previews/permission-controller": "11.0.6-preview-888fa154",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-888fa154",
  "@metamask-previews/phishing-controller": "12.4.1-preview-888fa154",
  "@metamask-previews/polling-controller": "13.0.0-preview-888fa154",
  "@metamask-previews/preferences-controller": "17.0.0-preview-888fa154",
  "@metamask-previews/profile-sync-controller": "11.0.0-preview-888fa154",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-888fa154",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-888fa154",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-888fa154",
  "@metamask-previews/sample-controllers": "0.1.0-preview-888fa154",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-888fa154",
  "@metamask-previews/signature-controller": "27.0.0-preview-888fa154",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-888fa154",
  "@metamask-previews/transaction-controller": "52.3.0-preview-888fa154",
  "@metamask-previews/user-operation-controller": "31.0.0-preview-888fa154"
}

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review April 2, 2025 15:23
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner April 2, 2025 15:23
@matthewwalsh0 matthewwalsh0 force-pushed the fix/incoming-transactions-recent-history branch 2 times, most recently from 856e82e to aa3d114 Compare April 9, 2025 13:39
@matthewwalsh0 matthewwalsh0 requested a review from OGPoyraz April 9, 2025 13:40
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner April 9, 2025 14:17
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) April 10, 2025 10:08
Query previous day if entire history disabled.
@matthewwalsh0 matthewwalsh0 force-pushed the fix/incoming-transactions-recent-history branch from 20adbaf to 9a4f7c7 Compare April 10, 2025 10:08
@matthewwalsh0 matthewwalsh0 merged commit deaf2dc into main Apr 10, 2025
198 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/incoming-transactions-recent-history branch April 10, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incoming transactions not displayed in activity tab
2 participants