chore: sends transaction update events#5587
Merged
Conversation
ccharly
reviewed
Apr 3, 2025
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Apr 3, 2025
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Apr 4, 2025
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
ccharly
approved these changes
Apr 4, 2025
zone-live
added a commit
that referenced
this pull request
Apr 7, 2025
## Explanation Releases the `multichain-transactions-controller`. ## References * Related to #5587 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/multichain-transactions-controller` - **ADDED**: sends transaction update events ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We are sending two events
transactionFinalizedandtransactionSubmittedin order to track these in the client, and send out the necessary metrics.References
Changelog
Checklist