Skip to content

refactor: migrate {Permission,SubjectMetadata}Controller to @metamask/messenger #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: migrate {Permission,SubjectMetadata}Controller to @metamask/messenger #6537

wants to merge 1 commit into from
+192 −173

Conversation

cryptodev-2s
Copy link
Contributor

Explanation

This PR migrates PermissionController and SubjectMetadataController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s self-assigned this Sep 9, 2025
@cryptodev-2s cryptodev-2s requested review from a team as code owners September 9, 2025 16:31
@cryptodev-2s cryptodev-2s mentioned this pull request Sep 9, 2025
Open
42 tasks
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/permission-controller branch from f9a357f to 94c5e2b Compare September 9, 2025 16:32
@cryptodev-2s cryptodev-2s changed the title refactor: migrate {Permission,SubjectMetadata}Controller to `@metamask/messenger refactor: migrate {Permission,SubjectMetadata}Controller to @metamask/messenger Sep 9, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/permission-controller branch from 94c5e2b to 84146fc Compare September 9, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

@cryptodev-2s cryptodev-2s

Labels
DO-NOT-MERGE team-core-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptodev-2s @mcmire