refactor: migrate {NotificationServices,NotificationServicesPush}Controller to `@metamask/messenger
#6538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
force-pushed
the
cryptodev-2s/messenger/notification-services-controller
branch
from
9449e6e to
851b86f
Compare
…roller to @metamask/messenger
cryptodev-2s
force-pushed
the
cryptodev-2s/messenger/notification-services-controller
branch
from
851b86f to
e948005
Compare
42 tasks
mcmire
reviewed
Sep 10, 2025
| isFeatureAnnouncementsEnabled: true, | ||
| isNotificationServicesEnabled: true, | ||
| }, | ||
| describe('NotificationServicesController', () => { |
There was a problem hiding this comment.
Should we reformat the tests in another PR? Otherwise this diff is somewhat difficult to read.
Comment on lines
+38
to
+50
| const globalMessenger = getRootMessenger(); | ||
|
|
||
| return globalMessenger.getRestricted< | ||
| 'NotificationServicesPushController', | ||
| AllowedActions['type'] | ||
| const messenger = new Messenger< | ||
| typeof controllerName, | ||
| AllNotificationServicesPushControllerActions, | ||
| AllNotificationServicesPushControllerEvents, | ||
| RootMessenger | ||
| >({ | ||
| name: 'NotificationServicesPushController', | ||
| allowedActions: ['AuthenticationController:getBearerToken'], | ||
| allowedEvents: [], | ||
| namespace: controllerName, | ||
| parent: globalMessenger, | ||
| }); | ||
|
|
||
| globalMessenger.delegate({ |
There was a problem hiding this comment.
Nit: Should we rename this variable to rootMessenger?
Suggested change
| const globalMessenger = getRootMessenger(); | |
| return globalMessenger.getRestricted< | |
| 'NotificationServicesPushController', | |
| AllowedActions['type'] | |
| const messenger = new Messenger< | |
| typeof controllerName, | |
| AllNotificationServicesPushControllerActions, | |
| AllNotificationServicesPushControllerEvents, | |
| RootMessenger | |
| >({ | |
| name: 'NotificationServicesPushController', | |
| allowedActions: ['AuthenticationController:getBearerToken'], | |
| allowedEvents: [], | |
| namespace: controllerName, | |
| parent: globalMessenger, | |
| }); | |
| globalMessenger.delegate({ | |
| const rootMessenger = getRootMessenger(); | |
| const messenger = new Messenger< | |
| typeof controllerName, | |
| AllNotificationServicesPushControllerActions, | |
| AllNotificationServicesPushControllerEvents, | |
| RootMessenger | |
| >({ | |
| namespace: controllerName, | |
| parent: rootMessenger, | |
| }); | |
| rootMessenger.delegate({ |
| @@ -195,7 +195,7 @@ export type Actions = | |||
| | NotificationServicesControllerDeleteNotificationsById; | |||
|
|
|||
| // Allowed Actions | |||
| export type AllowedActions = | |||
| type AllowedActions = | |||
There was a problem hiding this comment.
Because @metamask/notification-services-controller is using barrel exports in index.ts, I believe that if we don't export this type it will remove the export from the whole package, can you confirm? If so should we add this to the changelog?
| @@ -231,7 +231,7 @@ export type Events = | |||
| | MarkNotificationsAsReadEvent; | |||
|
|
|||
| // Allowed Events | |||
| export type AllowedEvents = | |||
| type AllowedEvents = | |||
There was a problem hiding this comment.
Similar as for AllowedActions.
| @@ -55,7 +55,7 @@ export type Actions = | |||
| | NotificationServicesPushControllerUpdateTriggerPushNotificationsAction | |||
| | NotificationServicesPushControllerSubscribeToNotificationsAction; | |||
|
|
|||
| export type AllowedActions = | |||
| type AllowedActions = | |||
There was a problem hiding this comment.
Similar comment as for NotificationServicesController.ts.
| @@ -79,14 +79,10 @@ export type Events = | |||
| | NotificationServicesPushControllerOnNewNotificationEvent | |||
| | NotificationServicesPushControllerPushNotificationClickedEvent; | |||
|
|
|||
| export type AllowedEvents = never; | |||
There was a problem hiding this comment.
Similar comment as for NotificationServicesController.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
NotificationServicesControllerandNotificationServicesPushControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist