feat: optimise transaction pay quote refresh #7008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
matthewwalsh0
changed the title
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Fix totals.
Calculate source network cost of all steps.
matthewwalsh0
force-pushed
the
fix/pay-polygon-bridge
branch
from
7df8698 to
7983b22
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| * | ||
| * @param quote - Relay quote. | ||
| * @param messenger - Controller messenger. | ||
| * @returns Total source network cost in USD and fiat. |
There was a problem hiding this comment.
what is the difference between USD and fiat? Is fiat the user's selected currency?
There was a problem hiding this comment.
Exactly, I've made a point of providing both everywhere so it's easy to access since Perps and Predict force USD everywhere.
I've confirmed the difference in the FiatRates and FiatValue JSDoc.
pedronfigueiredo
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Only check if transaction pay quotes need refreshing when quotes exist in the controller state.
Also:
isLoadingstate if quote update fails.References
Checklist
Note
Introduce quote-refresh polling based on existing quotes, correct feature flag keys, improve fee/fiat calculations, and refine transaction/quote refresh behavior.
src/TransactionPayController.ts):queueRefreshQuoteswithQuoteRefresherand ensureisLoadingreset afterupdateQuotes.QuoteRefresherto pollrefreshQuotesonly whentransactionDatacontains quotes; prevents concurrent updates and handles errors.bridge-quotes.ts):confirmations_payfeature flag key.request.sourceTokenAddressfor source fiat rate.relay-quotes.ts):confirmations_payfeature flag key.utils/quotes.ts):sourceAmountstotokensby address.refreshQuotes; remove internal polling; respect per-strategy refresh intervals; set loading during refresh.utils/totals.ts):skipIfBalancewhen balance ≥ amount from totals.utils/transaction.ts):CHANGELOG.mdwith fixes (ignore tokens without quotes; correct feature flag).Written by Cursor Bugbot for commit 7983b22. This will update automatically on new commits. Configure here.