Support 'workspace:^' notation in dependency versions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
changed the title
mcmire
reviewed
Dec 15, 2023
mcmire
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
I tested this out on snaps and this bug goes away. There is another bug that prevents create-release-branch from running, but that's because this tool doesn't support private packages yet. That's a separate issue and I'll make a ticket for it. Anyway, this looks good on its own though!
|
Follow up to this — it seems there were some empty directories in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request addresses the issue where the 'workspace:^' notation was not being recognized as a valid specifier for dependency/peerDependencies versions in our package.json files.
Changes Made
isValidPackageManifestVersionFieldto recognizeworkspace:^as a valid version.