-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release UI beta #166
Conversation
f5dc2c7
to
3251623
Compare
3251623
to
2385628
Compare
@SocketSecurity ignore-all @SocketSecurity ignore npm/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! I had some minor suggestions on various things I noticed, but I'm pretty happy with this.
I noticed that creating the release branch took more time than expected, but maybe that's how it's always been. Maybe something we can look at in a future PR.
Report too large to display inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉🎉
The Release UI Beta
You can test the new feature in
create-release-branch
locally with Core by following these steps:1️⃣ Checkout the Feature Branch
3️⃣ Run the Command in
create-release-branch
yarn && yarn build
4️⃣ Update Core’s package.json
4️⃣ Run the Command in Core
yarn && yarn create-release-branch -i
Fixes: #163