Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include unchanged dependents in release validation #173

Merged

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Mar 11, 2025

Description

This PR fixes an important visibility issue in our release process where packages that should be considered for release due to peer dependency updates weren't being surfaced to users during the release workflow if they had no changes since their latest release.

Technical Details

  • Modified findMissingUnreleasedDependents to consider all dependent packages, not just those with changes since their latest release
  • This ensures that all dependencies are properly validated during the release process, regardless of their change status

Fixes #164

@cryptodev-2s cryptodev-2s self-assigned this Mar 11, 2025
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner March 11, 2025 15:07
@cryptodev-2s cryptodev-2s marked this pull request as draft March 11, 2025 15:08
@cryptodev-2s cryptodev-2s marked this pull request as ready for review March 13, 2025 15:00
@cryptodev-2s cryptodev-2s requested a review from mcmire March 13, 2025 16:51
mcmire
mcmire previously approved these changes Mar 13, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nits but none of them are blocking. This looks good!

@cryptodev-2s cryptodev-2s enabled auto-merge (squash) March 13, 2025 21:06
@cryptodev-2s cryptodev-2s requested a review from mcmire March 14, 2025 22:34
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cryptodev-2s cryptodev-2s merged commit fd93e9c into main Mar 17, 2025
15 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix/include-unchanged-dependents-in-validation branch March 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants