fix: include unchanged dependents in release validation #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
previously approved these changes
Mar 13, 2025
mcmire
reviewed
Mar 14, 2025
cryptodev-2s
deleted the
cryptodev2s/fix/include-unchanged-dependents-in-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an important visibility issue in our release process where packages that should be considered for release due to peer dependency updates weren't being surfaced to users during the release workflow if they had no changes since their latest release.
Technical Details
findMissingUnreleasedDependentsto consider all dependent packages, not just those with changes since their latest releaseFixes #164