Skip to content

Assign messageId via local variable #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Assign messageId via local variable #144

wants to merge 3 commits into from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 3, 2022 •
edited
Loading

Relying on this.currentMessageId after we set the next ID could allow two rapid calls to obscure the callback number.

@darkwing darkwing requested a review from a team as a code owner May 3, 2022 21:37
Gudahtt
Gudahtt reviewed May 4, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this once the lint error is fixed, as this seems easier to read to me. But I am confident there are no functional changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darkwing @Gudahtt @digiwand