-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: webpack lavamoat node #38209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: webpack lavamoat node #38209
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +1 -1)
👨🔧 @MetaMask/extension-platform (1 files, +1 -0)
📜 @MetaMask/policy-reviewers (4 files, +3858 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Builds ready [02c48a6]
UI Startup Metrics (1194 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ffa04b2]
UI Startup Metrics (1285 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [60459ed]
UI Startup Metrics (1261 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on my machine!
Builds ready [bf8552b]
UI Startup Metrics (1298 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR makes the webpack build process run under lavamoat-node.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5839
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces LavaMoat Node execution for the webpack build and integrates policy generation/validation into CI.
webpack:lavamoat,webpack:lavamoat:build, andwebpack:lavamoat:generatescripts; update GH workflows to use them and add a new job forwebpack buildpolicylavamoat/webpack/buildand expand build-system overrides (e.g.,tsx>fsevents,typescriptglobals)development/webpack/launch.ts,fork.ts,tsconfig.json) and ignore compiled output in.gitignorehtml-bundler-webpack-pluginandtailwindcssfor LavaMoat compatibility; bump@lavamoat/webpackto1.5.6,lavamoatto10.0.5, andtypescriptto~5.6.0lavamoatpackages to.yarnrc.ymlpreapproved listuseBalanceChanges.test.ts(treat missing rate asundefined)Written by Cursor Bugbot for commit bf8552b. This will update automatically on new commits. Configure here.