Skip to content

fix: make account providers wait for Snap platform to be ready #39051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ccharly merged 9 commits into from
Jan 13, 2026
Merged

fix: make account providers wait for Snap platform to be ready #39051

ccharly merged 9 commits into from
Jan 13, 2026
+41 −31

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 6, 2026 •
edited by cursor bot
Loading

Description

Bumping the multichain-account-service package.

This new version now waits for the Snap platform to be ready before starting any Snap requests. This way we won't be facing early TimeoutError which was sometimes happening during onboarding.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Wait for the Snap platform to be ready before processing any non-EVM account operations (avoiding hitting TimeoutError during onboarding with Snaps)

Related issues

Fixes: #39119, #38429

Manual testing steps

  • Apply this patch to force the Snap platform init to be delayed (10s):
diff --git a/app/scripts/controller-init/snaps/snap-controller-init.ts b/app/scripts/controller-init/snaps/snap-controller-init.ts
index 2298c0540d..589895fab8 100644
--- a/app/scripts/controller-init/snaps/snap-controller-init.ts
+++ b/app/scripts/controller-init/snaps/snap-controller-init.ts
@@ -99,12 +99,25 @@ export const SnapControllerInit: ControllerInitFunction<
    *
    * @returns A promise that resolves when onboarding is complete.
    */
+  const deferred = createDeferredPromise();
   async function ensureOnboardingComplete() {
     const { completedOnboarding } = initMessenger.call(
       'OnboardingController:getState',
     );

     if (completedOnboarding) {
+      setTimeout(() => {
+        deferred.resolve();
+        console.log(
+          'TimeoutError check -- (early) Onboarding complete, continuing SnapController init!',
+        );
+      }, 10000);
+
+      console.log(
+        'TimeoutError check -- (early) Onboarding complete, waiting...',
+      );
+      await deferred.promise;
+
       return;
     }

@@ -112,16 +125,27 @@ export const SnapControllerInit: ControllerInitFunction<

     const listener = (state: OnboardingControllerState) => {
       if (state.completedOnboarding) {
-        resolve();
+        setTimeout(
+          () => () => {
+            resolve();
+            console.log(
+              'TimeoutError check -- Onboarding complete, continuing SnapController init!',
+            );
+          },
+          10000,
+        );
+
         initMessenger.unsubscribe('OnboardingController:stateChange', listener);
       }
     };

     initMessenger.subscribe('OnboardingController:stateChange', listener);

+    console.log('TimeoutError check -- Waiting for onboarding to complete...');
     await promise;
   }

+  console.log('TimeoutError check -- Initializing SnapController...');
   const controller = new SnapController({
     environmentEndowmentPermissions: Object.values(EndowmentPermissions),
     excludedPermissions: {
  • Onboard with a new SRP
  • Inspect and check your Console with the 'TimeoutError' string filter
    • BEFORE the fix, you should see some real TimeoutError being logged (Unable to discover accounts)
    • AFTER the fix, you should not see any of those errors, only the patch logs that got added

Screenshots/Recordings

Before

Screenshot 2026-01-12 at 11 45 31

After

Screenshot 2026-01-12 at 11 28 00

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Aligns the multichain account flow with Snap platform readiness and updates policies.

  • Upgrade @metamask/multichain-account-service to ^5.0.0 (brings newer snaps-* deps, lodash usage); update yarn.lock
  • Extend multichain-account-service-messenger to subscribe to SnapController:stateChange and allow SnapController:getState/handleRequest; remove ErrorReportingService:captureException
  • Update LavaMoat policies (browserify/webpack variants) to permit lodash under @metamask/multichain-account-service

Written by Cursor Bugbot for commit db2397a. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jan 6, 2026
@socket-security
Copy link

socket-security bot commented Jan 6, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​metamask/​multichain-account-service@​3.0.0 ⏵ 5.0.09810079 +197 +1100

View full report

@github-actions github-actions bot added the size-S label Jan 6, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026 •
edited
Loading

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (5 files, +10 -5)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +2 -1
      • 📁 experimental/
        • 📄 policy.json +2 -1
      • 📁 flask/
        • 📄 policy.json +2 -1
      • 📁 main/
        • 📄 policy.json +2 -1
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +2 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

Builds ready [1bf3ea7]
UI Startup Metrics (1294 ± 110 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12941014162411013561483
load1082871133910411491302
domContentLoaded1075865133210311421292
domInteractive2716105202481
firstPaint1906213302291951073
backgroundConnect21619826912222238
firstReactRender1493551628
getState361776114158
initialActions105112
loadScripts86664511191039331066
setupStore1263151325
numNetworkReqs171176171167
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup8136581121958561012
load657579101790693881
domContentLoaded652573101289689871
domInteractive251697192282
firstPaint1096139661138244
backgroundConnect2361312629102
firstReactRender15112841723
getState3414129194261
initialActions103112
loadScripts649571100588687868
setupStore1264571429
numNetworkReqs181181181169
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup14531165208417415591742
load1163991160911412431373
domContentLoaded1163991160811412431373
domInteractive74311993891140
firstPaint------
backgroundConnect60212134775174
firstReactRender1393941420
getState145123131535
initialActions103122
loadScripts112497714659711841299
setupStore144176181237
numNetworkReqs19984191374
BrowserifyPower User HomeuiStartup26301430473661829963643
load1771962289656822592690
domContentLoaded1770962289656822592689
domInteractive118251045177100406
firstPaint------
backgroundConnect4132213344069041111
firstReactRender20116192434
getState118621049125120169
initialActions206123
loadScripts1457948270947119242439
setupStore874111522152976
numNetworkReqs68192033874169
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 1bf3ea7 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±70ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 73ms 1.01s 1.33s 1.29s 1.33s
domContentLoaded 742ms 70ms 700ms 1.01s 961ms 1.01s
firstPaint 79ms 11ms 64ms 168ms 88ms 168ms
firstContentfulPaint 79ms 11ms 64ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.1%)
  • ui: 9 Bytes (0%)
  • common: 730 Bytes (0.01%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 7, 2026

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jan 7, 2026

Policy update failed. You can review the logs or retry the policy update here

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 7, 2026

Builds ready [f38c047]
UI Startup Metrics (1301 ± 123 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13011056166612313651529
load1089871143611811421323
domContentLoaded1082869142711711361315
domInteractive2615104192379
firstPaint160651135154185302
backgroundConnect21619825011223244
firstReactRender1474151627
getState34197593950
initialActions107112
loadScripts87466712161179351114
setupStore1172031218
numNetworkReqs171178161168
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup771613109990832931
load62454083472691778
domContentLoaded61953682672684772
domInteractive2414109192080
firstPaint1025531354136212
backgroundConnect2951363343102
firstReactRender1493851625
getState2813134163354
initialActions105114
loadScripts61653482471682763
setupStore1063651022
numNetworkReqs181175181171
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup13941053252121115031728
load1115904188513811861318
domContentLoaded1114904188513811861317
domInteractive65302263886147
firstPaint------
backgroundConnect55183555254170
firstReactRender1292531317
getState136116161125
initialActions102122
loadScripts1082890186313111421268
setupStore13499141341
numNetworkReqs19983191373
BrowserifyPower User HomeuiStartup25281451370854129443255
load1707990257354121812524
domContentLoaded1707990257354121802518
domInteractive9932102815889234
firstPaint------
backgroundConnect3901811754038811085
firstReactRender2011112122428
getState966019425113147
initialActions203123
loadScripts1414971238643219312267
setupStore245310412194
numNetworkReqs74481542885144
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: f38c047 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±69ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.01s 1.33s 1.27s 1.33s
domContentLoaded 737ms 69ms 695ms 999ms 946ms 999ms
firstPaint 77ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.1%)
  • ui: 8 Bytes (0%)
  • common: 730 Bytes (0.01%)

@socket-security
Copy link

socket-security bot commented Jan 9, 2026 •
edited
Loading

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@ccharly ccharly changed the title fix: make account providers wait for snap platform to be ready fix: make account providers wait for Snap platform to be ready Jan 9, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [530897e]
UI Startup Metrics (1260 ± 107 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1260994155410713261411
load1049815132310111141201
domContentLoaded1041808131710111091193
domInteractive251484182179
firstPaint201571151207190896
backgroundConnect21417328823230255
firstReactRender16108381827
getState3718113144465
initialActions105113
loadScripts835630109296897981
setupStore1375161524
numNetworkReqs181174181171
BrowserifyPower User HomeuiStartup19041612263820719462380
load1041905164312510691306
domContentLoaded1028900162812610641297
domInteractive37182433434119
firstPaint193711315144234415
backgroundConnect25721070396242600
firstReactRender22155862430
getState17413325726191222
initialActions103112
loadScripts81568914171238431073
setupStore18969101841
numNetworkReqs57381372262115
WebpackStandard HomeuiStartup800658105275843953
load64458087262669772
domContentLoaded63957586661664767
domInteractive251688172179
firstPaint1015926942118192
backgroundConnect2751473138116
firstReactRender15102831720
getState3314125194365
initialActions104111
loadScripts63657285860661764
setupStore1163451323
numNetworkReqs171179171167
WebpackPower User HomeuiStartup1291999202222914011719
load679593104888688876
domContentLoaded669583104488675867
domInteractive35171693132118
firstPaint1416786199160278
backgroundConnect62762714119540
firstReactRender22173532329
getState15412925625157227
initialActions103111
loadScripts666581103686672864
setupStore16104871735
numNetworkReqs923824448136226
FirefoxBrowserifyStandard HomeuiStartup14061099240522315081730
load1118923222418011791313
domContentLoaded1118922222418011791313
domInteractive7432122812285142
firstPaint------
backgroundConnect52181974455176
firstReactRender13103741325
getState166212291430
initialActions102022
loadScripts1086908220817011321247
setupStore155164191240
numNetworkReqs19979191375
BrowserifyPower User HomeuiStartup25521830551859525444315
load12461054286727112181691
domContentLoaded12461054286727112181691
domInteractive1223553599118424
firstPaint------
backgroundConnect112261073147103260
firstReactRender22153142530
getState28083850218406713
initialActions214123
loadScripts12031021268322111821611
setupStore15015837188144567
numNetworkReqs57302144845192
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 530897e | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±103ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±124ms) 🟢 | historical mean value: 716ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±96ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 103ms 999ms 1.85s 1.25s 1.85s
domContentLoaded 736ms 124ms 692ms 1.81s 927ms 1.81s
firstPaint 84ms 96ms 56ms 1.03s 88ms 1.03s
firstContentfulPaint 84ms 96ms 56ms 1.03s 88ms 1.03s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 164.84 KiB (3.42%)
  • ui: -3.65 KiB (-0.05%)
  • common: 7.59 KiB (0.08%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 9, 2026

@SocketSecurity ignore npm/@metamask/[email protected]

This is an internal package.

@ccharly ccharly mentioned this pull request Jan 9, 2026
Closed
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [812f723]
UI Startup Metrics (1341 ± 136 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13411075185813614141614
load1117897150711911811353
domContentLoaded1109890149911911751346
domInteractive2916108222394
firstPaint201621210181200318
backgroundConnect23720829414244267
firstReactRender1796382030
getState401892154969
initialActions1012214
loadScripts88167712571169411112
setupStore1364461525
numNetworkReqs181176181172
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup810671103381851991
load64558483361664780
domContentLoaded64057982661658772
domInteractive261697202187
firstPaint1006024043107210
backgroundConnect3251893443106
firstReactRender16114541723
getState341579144262
initialActions104111
loadScripts63757682359655764
setupStore1475591339
numNetworkReqs171179171168
WebpackPower User HomeuiStartup13631004201025615021931
load68559890476708871
domContentLoaded67559289976692864
domInteractive35171483031121
firstPaint1456541971193275
backgroundConnect62766414118549
firstReactRender23194442529
getState1617674263161221
initialActions104112
loadScripts67258988975689856
setupStore17104581842
numNetworkReqs923524648134210
FirefoxBrowserifyStandard HomeuiStartup14261087253221915401815
load1138923217016611911376
domContentLoaded1137923217016611911375
domInteractive65322293990136
firstPaint------
backgroundConnect68213486088173
firstReactRender13102331319
getState156199241141
initialActions103122
loadScripts1094908207114711481303
setupStore174270311348
numNetworkReqs19986191474
BrowserifyPower User HomeuiStartup25191951491760924824219
load12661016275936012562459
domContentLoaded12661016275936012562458
domInteractive124371074132111401
firstPaint------
backgroundConnect118231061163114263
firstReactRender251578122659
getState24763824199306697
initialActions207123
loadScripts1220998257131511802251
setupStore14610770189126573
numNetworkReqs59292114848195
WebpackStandard HomeuiStartup15581278211517316651905
load13181116162011813881554
domContentLoaded13181116162011813881553
domInteractive762817440107137
firstPaint------
backgroundConnect61162844775142
firstReactRender14104041521
getState198175261661
initialActions102122
loadScripts12801101159710213241453
setupStore166125191552
numNetworkReqs19983191573
WebpackPower User HomeuiStartup27562035610975527454333
load15351180326247516502610
domContentLoaded15351180326147516502610
domInteractive132321046171104497
firstPaint------
backgroundConnect1892313642841331006
firstReactRender2715166212661
getState27078961230397765
initialActions214123
loadScripts14201161293133915192136
setupStore1181267914798472
numNetworkReqs58292084647187
📊 Page Load Benchmark Results

Current Commit: 812f723 | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±68ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.00s 1.33s 1.28s 1.33s
domContentLoaded 734ms 68ms 695ms 1.00s 946ms 1.00s
firstPaint 77ms 14ms 60ms 200ms 88ms 200ms
firstContentfulPaint 77ms 14ms 60ms 200ms 88ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 164.84 KiB (3.42%)
  • ui: -14.56 KiB (-0.19%)
  • common: 6.08 KiB (0.07%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 9, 2026

@metamaskbot update-policies

@ccharly ccharly self-assigned this Jan 12, 2026
@ccharly ccharly marked this pull request as ready for review January 12, 2026 09:58
@ccharly ccharly requested a review from a team as a code owner January 12, 2026 09:58
@ccharly ccharly enabled auto-merge January 12, 2026 15:11
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 12, 2026

Builds ready [27dafe8]
UI Startup Metrics (1361 ± 138 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13611068186413814501600
load--1139877147313012371356
domContentLoaded--1132875146413012311351
domInteractive--2716113212388
firstPaint--181661300184206325
backgroundConnect--22119927015230247
firstReactRender--17103972035
getState--4018111174580
initialActions--106113
loadScripts--920657124513010051120
setupStore--1372741623
numNetworkReqs--171177161163
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--19091603256420920212370
load--1033910140311910481318
domContentLoaded--1020904139312010381311
domInteractive--35171572931120
firstPaint--192691425151238376
backgroundConnect--281203774136248609
firstReactRender--22164852331
getState--17513874661186213
initialActions--103011
loadScripts--80769711781158121079
setupStore--198126131835
numNetworkReqs--60381642761129
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--794656112777828939
load--63557082663658783
domContentLoaded--62956582163653778
domInteractive--251696192284
firstPaint--1135733057158216
backgroundConnect--3351243457106
firstReactRender--15113231720
getState--3115127164058
initialActions--104112
loadScripts--62656381961650769
setupStore--1163841216
numNetworkReqs--171175171168
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13241004193024214521890
load--697589106095700927
domContentLoaded--686580105396690921
domInteractive--39182513537121
firstPaint--1466644478202303
backgroundConnect--69760515718543
firstReactRender--23174142533
getState--15713177965159189
initialActions--102011
loadScripts--683578104494687913
setupStore--16105171739
numNetworkReqs--1033823547138213
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15401177233921316361995
load--12191002189315612911447
domContentLoaded--12191002189315712911447
domInteractive--77332113997143
firstPaint--------
backgroundConnect--792136468125204
firstReactRender--14102931420
getState--1467491528
initialActions--103122
loadScripts--1169986186213312111364
setupStore--164157201450
numNetworkReqs--19981181571
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25952011594767025584195
load--13321065277740913332568
domContentLoaded--13321064277740913332567
domInteractive--12838986129120385
firstPaint--------
backgroundConnect--145242896312106337
firstReactRender--23157382435
getState--26365805213359713
initialActions--207123
loadScripts--12771044260836212782394
setupStore--1278728156144508
numNetworkReqs--60301974366187
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15291226366027315741906
load--12881091348024713371533
domContentLoaded--12881091348024813371533
domInteractive--9430204720099146
firstPaint--------
backgroundConnect--50161943850143
firstReactRender--15103841624
getState--206225361598
initialActions--103122
loadScripts--12561070345824312921468
setupStore--14697111536
numNetworkReqs--20985201480
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28362209531461428334248
load--15721289328439716222608
domContentLoaded--15711289328439716222607
domInteractive--129341034150108485
firstPaint--------
backgroundConnect--1733611332621221047
firstReactRender--2716111123038
getState--304571603262411822
initialActions--218123
loadScripts--14721230234224215762024
setupStore--1459602163215567
numNetworkReqs--60311984555179
19--------
📊 Page Load Benchmark Results

Current Commit: 27dafe8 | Date: 1/12/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±66ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±63ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 66ms 1.02s 1.35s 1.29s 1.35s
domContentLoaded 738ms 63ms 707ms 1.02s 966ms 1.02s
firstPaint 78ms 13ms 60ms 196ms 88ms 196ms
firstContentfulPaint 78ms 13ms 60ms 196ms 88ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.09%)
  • ui: -16 Bytes (0%)
  • common: 21 Bytes (0%)

@ccharly ccharly added this pull request to the merge queue Jan 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 12, 2026
@hmalik88 hmalik88 added this pull request to the merge queue Jan 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 13, 2026
@ccharly ccharly enabled auto-merge January 13, 2026 07:23
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 13, 2026

Builds ready [db2397a]
UI Startup Metrics (1366 ± 129 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13661086173412914501608
load--1149922150111512191333
domContentLoaded--1142918149611512131314
domInteractive--2916112212590
firstPaint--222671225226212960
backgroundConnect--22520827211230250
firstReactRender--17103951928
getState--391897144867
initialActions--104112
loadScripts--925704128011510001102
setupStore--1584361725
numNetworkReqs--171174171168
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--------
load--------
domContentLoaded--------
domInteractive--------
firstPaint--------
backgroundConnect--------
firstReactRender--------
getState--------
initialActions--------
loadScripts--------
setupStore--------
numNetworkReqs--------
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--804645118097848996
load--64757391879685823
domContentLoaded--64257090578682818
domInteractive--251595192386
firstPaint--1146162477150226
backgroundConnect--325125334998
firstReactRender--15103941721
getState--3015131163858
initialActions--104111
loadScripts--63956789676679810
setupStore--1273871231
numNetworkReqs--181176181173
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1374980227928915871992
load--67459193582687882
domContentLoaded--66458692982677875
domInteractive--35181462833120
firstPaint--1236333862146258
backgroundConnect--91764317434551
firstReactRender--22173332429
getState--1607076887156175
initialActions--103111
loadScripts--66158492181674870
setupStore--15104461620
numNetworkReqs--983624549134228
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13831085213420214381878
load--1103930172614611481349
domContentLoaded--1102929172514611481348
domInteractive--68312604288148
firstPaint--------
backgroundConnect--57212104569156
firstReactRender--1292821317
getState--136175201136
initialActions--103122
loadScripts--1067913159012511131276
setupStore--144113161051
numNetworkReqs--20988201479
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25131824528663325244147
load--1235968273832911682023
domContentLoaded--1234963273832911682023
domInteractive--11731555104113418
firstPaint--------
backgroundConnect--141221176213126861
firstReactRender--2416158152432
getState--27877856220384771
initialActions--209123
loadScripts--1188952266628611291864
setupStore--1217814171121582
numNetworkReqs--60312214850201
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15641275206519516621975
load--13051069180513213951547
domContentLoaded--13051069180513213941547
domInteractive--72282334091137
firstPaint--------
backgroundConnect--63191884481153
firstReactRender--14112731620
getState--2372453716132
initialActions--102022
loadScripts--12641056164811113341443
setupStore--204154261769
numNetworkReqs--20989191477
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28742140483171829784475
load--16151174308851216402931
domContentLoaded--16141174308751216402931
domInteractive--11629706113113329
firstPaint--------
backgroundConnect--1782316322911321085
firstReactRender--251699112839
getState--30677893255525824
initialActions--301081125
loadScripts--15201150307042015132670
setupStore--113869915195478
numNetworkReqs--58311893681151
19--------
📊 Page Load Benchmark Results

Current Commit: db2397a | Date: 1/13/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±126ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 710ms (±148ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 87ms (±119ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 126ms 954ms 2.09s 1.24s 2.09s
domContentLoaded 710ms 148ms 660ms 2.04s 919ms 2.04s
firstPaint 87ms 119ms 60ms 1.27s 84ms 1.27s
firstContentfulPaint 87ms 119ms 60ms 1.27s 84ms 1.27s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.09%)
  • ui: -16 Bytes (0%)
  • common: 21 Bytes (0%)

@ccharly ccharly added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 13, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 13, 2026

Builds ready [db2397a]
UI Startup Metrics (1366 ± 129 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13661086173412914501608
load--1149922150111512191333
domContentLoaded--1142918149611512131314
domInteractive--2916112212590
firstPaint--222671225226212960
backgroundConnect--22520827211230250
firstReactRender--17103951928
getState--391897144867
initialActions--104112
loadScripts--925704128011510001102
setupStore--1584361725
numNetworkReqs--171174171168
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--18821674259917619552347
load--1026906136211010551298
domContentLoaded--1015896134510910471277
domInteractive--32161092331104
firstPaint--1746840585239354
backgroundConnect--263202651106247566
firstReactRender--22155272438
getState--17013724524186215
initialActions--104112
loadScripts--80368911041058201060
setupStore--1895291740
numNetworkReqs--59371462561130
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--804645118097848996
load--64757391879685823
domContentLoaded--64257090578682818
domInteractive--251595192386
firstPaint--1146162477150226
backgroundConnect--325125334998
firstReactRender--15103941721
getState--3015131163858
initialActions--104111
loadScripts--63956789676679810
setupStore--1273871231
numNetworkReqs--181176181173
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1374980227928915871992
load--67459193582687882
domContentLoaded--66458692982677875
domInteractive--35181462833120
firstPaint--1236333862146258
backgroundConnect--91764317434551
firstReactRender--22173332429
getState--1607076887156175
initialActions--103111
loadScripts--66158492181674870
setupStore--15104461620
numNetworkReqs--983624549134228
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13831085213420214381878
load--1103930172614611481349
domContentLoaded--1102929172514611481348
domInteractive--68312604288148
firstPaint--------
backgroundConnect--57212104569156
firstReactRender--1292821317
getState--136175201136
initialActions--103122
loadScripts--1067913159012511131276
setupStore--144113161051
numNetworkReqs--20988201479
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--25131824528663325244147
load--1235968273832911682023
domContentLoaded--1234963273832911682023
domInteractive--11731555104113418
firstPaint--------
backgroundConnect--141221176213126861
firstReactRender--2416158152432
getState--27877856220384771
initialActions--209123
loadScripts--1188952266628611291864
setupStore--1217814171121582
numNetworkReqs--60312214850201
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--15641275206519516621975
load--13051069180513213951547
domContentLoaded--13051069180513213941547
domInteractive--72282334091137
firstPaint--------
backgroundConnect--63191884481153
firstReactRender--14112731620
getState--2372453716132
initialActions--102022
loadScripts--12641056164811113341443
setupStore--204154261769
numNetworkReqs--20989191477
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28742140483171829784475
load--16151174308851216402931
domContentLoaded--16141174308751216402931
domInteractive--11629706113113329
firstPaint--------
backgroundConnect--1782316322911321085
firstReactRender--251699112839
getState--30677893255525824
initialActions--301081125
loadScripts--15201150307042015132670
setupStore--113869915195478
numNetworkReqs--58311893681151
19--------
📊 Page Load Benchmark Results

Current Commit: db2397a | Date: 1/13/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±126ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 710ms (±148ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 87ms (±119ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 126ms 954ms 2.09s 1.24s 2.09s
domContentLoaded 710ms 148ms 660ms 2.04s 919ms 2.04s
firstPaint 87ms 119ms 60ms 1.27s 84ms 1.27s
firstContentfulPaint 87ms 119ms 60ms 1.27s 84ms 1.27s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.09%)
  • ui: -16 Bytes (0%)
  • common: 21 Bytes (0%)

@ccharly ccharly added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 9945e25 Jan 13, 2026
348 of 349 checks passed
@ccharly ccharly deleted the cc/fix/account-providers-wait-for-snap-platform branch January 13, 2026 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
@metamaskbot metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees

@ccharly ccharly

Labels

release-13.15.0 Issue or pull request that will be included in release 13.15.0 size-S team-accounts-framework Accounts Framework team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Unable to create account with provider "Solana" (or "Bitcoin" or "Tron")

5 participants

@ccharly @metamaskbot @gantunesr @hmalik88