Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 6, 2026

Description

Bumping the multichain-account-service package.

This new version now waits for the Snap platform to be ready before starting any Snap requests. This way we won't be facing early TimeoutError which was sometimes happening during onboarding.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: TODO

Related issues

Fixes: #39119, #38429

Manual testing steps

TODO

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jan 6, 2026
@socket-security
Copy link

socket-security bot commented Jan 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​multichain-account-service@​3.0.0 ⏵ 5.0.09810079 +197 +1100

View full report

@github-actions github-actions bot added the size-S label Jan 6, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (6 files, +22 -11)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +4 -2
      • 📁 experimental/
        • 📄 policy.json +4 -2
      • 📁 flask/
        • 📄 policy.json +4 -2
      • 📁 main/
        • 📄 policy.json +4 -2
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +4 -2
      • 📁 mv3/
        • 📄 policy.json +2 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

Builds ready [1bf3ea7]
UI Startup Metrics (1294 ± 110 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12941014162411013561483
load1082871133910411491302
domContentLoaded1075865133210311421292
domInteractive2716105202481
firstPaint1906213302291951073
backgroundConnect21619826912222238
firstReactRender1493551628
getState361776114158
initialActions105112
loadScripts86664511191039331066
setupStore1263151325
numNetworkReqs171176171167
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup8136581121958561012
load657579101790693881
domContentLoaded652573101289689871
domInteractive251697192282
firstPaint1096139661138244
backgroundConnect2361312629102
firstReactRender15112841723
getState3414129194261
initialActions103112
loadScripts649571100588687868
setupStore1264571429
numNetworkReqs181181181169
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup14531165208417415591742
load1163991160911412431373
domContentLoaded1163991160811412431373
domInteractive74311993891140
firstPaint------
backgroundConnect60212134775174
firstReactRender1393941420
getState145123131535
initialActions103122
loadScripts112497714659711841299
setupStore144176181237
numNetworkReqs19984191374
BrowserifyPower User HomeuiStartup26301430473661829963643
load1771962289656822592690
domContentLoaded1770962289656822592689
domInteractive118251045177100406
firstPaint------
backgroundConnect4132213344069041111
firstReactRender20116192434
getState118621049125120169
initialActions206123
loadScripts1457948270947119242439
setupStore874111522152976
numNetworkReqs68192033874169
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 1bf3ea7 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±70ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 73ms 1.01s 1.33s 1.29s 1.33s
domContentLoaded 742ms 70ms 700ms 1.01s 961ms 1.01s
firstPaint 79ms 11ms 64ms 168ms 88ms 168ms
firstContentfulPaint 79ms 11ms 64ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.1%)
  • ui: 9 Bytes (0%)
  • common: 730 Bytes (0.01%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 7, 2026

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 7, 2026

Builds ready [f38c047]
UI Startup Metrics (1301 ± 123 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13011056166612313651529
load1089871143611811421323
domContentLoaded1082869142711711361315
domInteractive2615104192379
firstPaint160651135154185302
backgroundConnect21619825011223244
firstReactRender1474151627
getState34197593950
initialActions107112
loadScripts87466712161179351114
setupStore1172031218
numNetworkReqs171178161168
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup771613109990832931
load62454083472691778
domContentLoaded61953682672684772
domInteractive2414109192080
firstPaint1025531354136212
backgroundConnect2951363343102
firstReactRender1493851625
getState2813134163354
initialActions105114
loadScripts61653482471682763
setupStore1063651022
numNetworkReqs181175181171
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup13941053252121115031728
load1115904188513811861318
domContentLoaded1114904188513811861317
domInteractive65302263886147
firstPaint------
backgroundConnect55183555254170
firstReactRender1292531317
getState136116161125
initialActions102122
loadScripts1082890186313111421268
setupStore13499141341
numNetworkReqs19983191373
BrowserifyPower User HomeuiStartup25281451370854129443255
load1707990257354121812524
domContentLoaded1707990257354121802518
domInteractive9932102815889234
firstPaint------
backgroundConnect3901811754038811085
firstReactRender2011112122428
getState966019425113147
initialActions203123
loadScripts1414971238643219312267
setupStore245310412194
numNetworkReqs74481542885144
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: f38c047 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±69ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.01s 1.33s 1.27s 1.33s
domContentLoaded 737ms 69ms 695ms 999ms 946ms 999ms
firstPaint 77ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 4.72 KiB (0.1%)
  • ui: 8 Bytes (0%)
  • common: 730 Bytes (0.01%)

@socket-security
Copy link

socket-security bot commented Jan 9, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@ccharly ccharly changed the title fix: make account providers wait for snap platform to be ready fix: make account providers wait for Snap platform to be ready Jan 9, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [530897e]
UI Startup Metrics (1260 ± 107 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1260994155410713261411
load1049815132310111141201
domContentLoaded1041808131710111091193
domInteractive251484182179
firstPaint201571151207190896
backgroundConnect21417328823230255
firstReactRender16108381827
getState3718113144465
initialActions105113
loadScripts835630109296897981
setupStore1375161524
numNetworkReqs181174181171
BrowserifyPower User HomeuiStartup19041612263820719462380
load1041905164312510691306
domContentLoaded1028900162812610641297
domInteractive37182433434119
firstPaint193711315144234415
backgroundConnect25721070396242600
firstReactRender22155862430
getState17413325726191222
initialActions103112
loadScripts81568914171238431073
setupStore18969101841
numNetworkReqs57381372262115
WebpackStandard HomeuiStartup800658105275843953
load64458087262669772
domContentLoaded63957586661664767
domInteractive251688172179
firstPaint1015926942118192
backgroundConnect2751473138116
firstReactRender15102831720
getState3314125194365
initialActions104111
loadScripts63657285860661764
setupStore1163451323
numNetworkReqs171179171167
WebpackPower User HomeuiStartup1291999202222914011719
load679593104888688876
domContentLoaded669583104488675867
domInteractive35171693132118
firstPaint1416786199160278
backgroundConnect62762714119540
firstReactRender22173532329
getState15412925625157227
initialActions103111
loadScripts666581103686672864
setupStore16104871735
numNetworkReqs923824448136226
FirefoxBrowserifyStandard HomeuiStartup14061099240522315081730
load1118923222418011791313
domContentLoaded1118922222418011791313
domInteractive7432122812285142
firstPaint------
backgroundConnect52181974455176
firstReactRender13103741325
getState166212291430
initialActions102022
loadScripts1086908220817011321247
setupStore155164191240
numNetworkReqs19979191375
BrowserifyPower User HomeuiStartup25521830551859525444315
load12461054286727112181691
domContentLoaded12461054286727112181691
domInteractive1223553599118424
firstPaint------
backgroundConnect112261073147103260
firstReactRender22153142530
getState28083850218406713
initialActions214123
loadScripts12031021268322111821611
setupStore15015837188144567
numNetworkReqs57302144845192
WebpackStandard HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 530897e | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±103ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±124ms) 🟢 | historical mean value: 716ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 84ms (±96ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 103ms 999ms 1.85s 1.25s 1.85s
domContentLoaded 736ms 124ms 692ms 1.81s 927ms 1.81s
firstPaint 84ms 96ms 56ms 1.03s 88ms 1.03s
firstContentfulPaint 84ms 96ms 56ms 1.03s 88ms 1.03s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 164.84 KiB (3.42%)
  • ui: -3.65 KiB (-0.05%)
  • common: 7.59 KiB (0.08%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 9, 2026

@SocketSecurity ignore npm/@metamask/[email protected]

This is an internal package.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [812f723]
UI Startup Metrics (1341 ± 136 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13411075185813614141614
load1117897150711911811353
domContentLoaded1109890149911911751346
domInteractive2916108222394
firstPaint201621210181200318
backgroundConnect23720829414244267
firstReactRender1796382030
getState401892154969
initialActions1012214
loadScripts88167712571169411112
setupStore1364461525
numNetworkReqs181176181172
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup810671103381851991
load64558483361664780
domContentLoaded64057982661658772
domInteractive261697202187
firstPaint1006024043107210
backgroundConnect3251893443106
firstReactRender16114541723
getState341579144262
initialActions104111
loadScripts63757682359655764
setupStore1475591339
numNetworkReqs171179171168
WebpackPower User HomeuiStartup13631004201025615021931
load68559890476708871
domContentLoaded67559289976692864
domInteractive35171483031121
firstPaint1456541971193275
backgroundConnect62766414118549
firstReactRender23194442529
getState1617674263161221
initialActions104112
loadScripts67258988975689856
setupStore17104581842
numNetworkReqs923524648134210
FirefoxBrowserifyStandard HomeuiStartup14261087253221915401815
load1138923217016611911376
domContentLoaded1137923217016611911375
domInteractive65322293990136
firstPaint------
backgroundConnect68213486088173
firstReactRender13102331319
getState156199241141
initialActions103122
loadScripts1094908207114711481303
setupStore174270311348
numNetworkReqs19986191474
BrowserifyPower User HomeuiStartup25191951491760924824219
load12661016275936012562459
domContentLoaded12661016275936012562458
domInteractive124371074132111401
firstPaint------
backgroundConnect118231061163114263
firstReactRender251578122659
getState24763824199306697
initialActions207123
loadScripts1220998257131511802251
setupStore14610770189126573
numNetworkReqs59292114848195
WebpackStandard HomeuiStartup15581278211517316651905
load13181116162011813881554
domContentLoaded13181116162011813881553
domInteractive762817440107137
firstPaint------
backgroundConnect61162844775142
firstReactRender14104041521
getState198175261661
initialActions102122
loadScripts12801101159710213241453
setupStore166125191552
numNetworkReqs19983191573
WebpackPower User HomeuiStartup27562035610975527454333
load15351180326247516502610
domContentLoaded15351180326147516502610
domInteractive132321046171104497
firstPaint------
backgroundConnect1892313642841331006
firstReactRender2715166212661
getState27078961230397765
initialActions214123
loadScripts14201161293133915192136
setupStore1181267914798472
numNetworkReqs58292084647187
📊 Page Load Benchmark Results

Current Commit: 812f723 | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±68ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.00s 1.33s 1.28s 1.33s
domContentLoaded 734ms 68ms 695ms 1.00s 946ms 1.00s
firstPaint 77ms 14ms 60ms 200ms 88ms 200ms
firstContentfulPaint 77ms 14ms 60ms 200ms 88ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 164.84 KiB (3.42%)
  • ui: -14.56 KiB (-0.19%)
  • common: 6.08 KiB (0.07%)

@ccharly
Copy link
Contributor Author

ccharly commented Jan 9, 2026

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 9, 2026

Builds ready [e337073]
UI Startup Metrics (1290 ± 107 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12901004159010713471475
load107084513719511231181
domContentLoaded106384013639511151175
domInteractive261597192185
firstPaint2416212872801981107
backgroundConnect22219429015227250
firstReactRender1694361828
getState3517145173967
initialActions109114
loadScripts850652114994905966
setupStore1284461327
numNetworkReqs181183191174
BrowserifyPower User HomeuiStartup18631502246918719112337
load1005894163010610231241
domContentLoaded992889161510710081233
domInteractive32171772530100
firstPaint179671254170221281
backgroundConnect267203661118231605
firstReactRender22155162335
getState17713931131192237
initialActions104112
loadScripts78268314101057881024
setupStore1664661731
numNetworkReqs57381302059115
WebpackStandard HomeuiStartup78164999975820945
load63457180163668766
domContentLoaded62956779762662756
domInteractive231588171976
firstPaint1115963288125283
backgroundConnect3351213455106
firstReactRender15103441625
getState2915125163755
initialActions104112
loadScripts62656578861659750
setupStore1154061129
numNetworkReqs171178161165
WebpackPower User HomeuiStartup1334984212026614981872
load67659098185684886
domContentLoaded66758297485680882
domInteractive34181592832111
firstPaint1336640878160313
backgroundConnect92764317925569
firstReactRender22163642530
getState14713018111154171
initialActions103112
loadScripts66458096584677874
setupStore1665281841
numNetworkReqs983825949134219
FirefoxBrowserifyStandard HomeuiStartup13561085197817114631651
load1093924153311411591307
domContentLoaded1093924153211411581307
domInteractive68313044690148
firstPaint------
backgroundConnect58212104982169
firstReactRender1292531318
getState135151171124
initialActions102112
loadScripts105791013699411181241
setupStore134146161137
numNetworkReqs19981191375
BrowserifyPower User HomeuiStartup25391928673971225014091
load1284996535953212252511
domContentLoaded1284995535953212252511
domInteractive148313810378108362
firstPaint------
backgroundConnect10625881116112259
firstReactRender22156362532
getState28061846227453750
initialActions203123
loadScripts1241977534251911862398
setupStore1348769174114570
numNetworkReqs59291753688134
WebpackStandard HomeuiStartup16611280248324117982187
load13841147206917615071726
domContentLoaded13841147206917615071726
domInteractive82292404192147
firstPaint------
backgroundConnect711825253118172
firstReactRender16116061823
getState218147221960
initialActions103122
loadScripts13371117202516014201633
setupStore2242383514121
numNetworkReqs19985201477
WebpackPower User HomeuiStartup293321246830100628165000
load16651181531170717313130
domContentLoaded16651180531170717313130
domInteractive142301172201117551
firstPaint------
backgroundConnect1692211722561321035
firstReactRender2616266262532
getState250751869256350734
initialActions218123
loadScripts15591165528959016642799
setupStore129111043199100598
numNetworkReqs59291994251180
📊 Page Load Benchmark Results

Current Commit: e337073 | Date: 1/9/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 718ms (±36ms) 🟢 | historical mean value: 719ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 38ms 1.00s 1.31s 1.06s 1.31s
domContentLoaded 718ms 36ms 692ms 988ms 751ms 988ms
firstPaint 75ms 10ms 60ms 152ms 84ms 152ms
firstContentfulPaint 75ms 10ms 60ms 152ms 84ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 164.84 KiB (3.42%)
  • ui: -14.56 KiB (-0.19%)
  • common: 6.08 KiB (0.07%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Unable to create account with provider "Solana" (or "Bitcoin" or "Tron")

3 participants