chore: migrate eth-json-rpc-filters to use JsonRpcEngineV2 #39057

rekmarks · 2026-01-07T00:53:59Z

Summary

Update @metamask/eth-json-rpc-filters to use V2 middleware format
Wrap V2 middleware with asLegacyMiddleware for V1 engine compatibility
Refactor createMetamaskMiddleware to return array of V2 middleware
Combine filter, subscription, and metamask middleware into single V2 engine in provider setup

Test plan

Verify filter methods (eth_newFilter, eth_newBlockFilter, eth_getFilterChanges, etc.) work correctly
Verify subscription methods (eth_subscribe, eth_unsubscribe) work correctly
Test multichain API subscription functionality

🤖 Generated with Claude Code

- Update @metamask/eth-json-rpc-filters to use V2 middleware - Wrap V2 middleware with asLegacyMiddleware for V1 engine compatibility - Refactor createMetamaskMiddleware to return array of V2 middleware - Combine filter, subscription, and metamask middleware into single V2 engine 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

metamaskbotv2 · 2026-01-07T00:56:37Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/wallet-integrations (1 files, +22 -29)

📁 app/
- 📁 scripts/
  - 📁 lib/
    - 📄 createMetamaskMiddleware.ts +22 -29

metamaskbotv2 · 2026-01-07T01:26:09Z

Builds ready [7a41f69]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1275 ± 109 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1275	1054	1585	109	1331	1443
			load	1072	875	1318	101	1137	1248
			domContentLoaded	1066	862	1308	100	1129	1239
			domInteractive	26	15	110	21	23	89
			firstPaint	171	66	1155	172	189	339
			backgroundConnect	213	195	271	11	217	235
			firstReactRender	15	9	34	6	16	30
			getState	33	16	70	10	40	51
			initialActions	1	0	7	1	1	2
			loadScripts	860	664	1112	100	922	1032
			setupStore	12	8	51	5	12	20
			numNetworkReqs	17	11	75	17	11	66
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	810	668	1118	89	857	1001
			load	648	583	950	69	660	798
			domContentLoaded	643	578	943	68	653	788
			domInteractive	26	16	95	20	23	83
			firstPaint	105	62	426	57	122	213
			backgroundConnect	28	5	131	28	38	115
			firstReactRender	15	11	36	5	16	26
			getState	34	15	127	19	44	65
			initialActions	1	0	4	1	1	2
			loadScripts	639	576	934	67	651	778
			setupStore	10	6	29	4	11	17
			numNetworkReqs	17	11	74	16	11	66
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1430	1114	2616	230	1532	1835
			load	1145	936	2384	198	1195	1386
			domContentLoaded	1144	936	2383	198	1195	1386
			domInteractive	88	32	1310	129	95	145
			firstPaint	-	-	-	-	-	-
			backgroundConnect	67	19	249	56	114	179
			firstReactRender	14	9	91	10	13	25
			getState	14	6	139	16	12	26
			initialActions	1	0	2	0	1	2
			loadScripts	1102	921	2361	183	1139	1277
			setupStore	17	4	109	21	13	79
			numNetworkReqs	20	9	91	20	14	78
	Browserify	Power User Home	uiStartup	2296	1416	2926	453	2636	2869
			load	1576	969	2355	455	1995	2236
			domContentLoaded	1575	969	2355	455	1994	2234
			domInteractive	75	35	443	69	70	272
			firstPaint	-	-	-	-	-	-
			backgroundConnect	393	20	1057	405	910	1011
			firstReactRender	20	11	62	7	24	26
			getState	82	55	197	23	88	126
			initialActions	2	0	7	1	2	3
			loadScripts	1231	953	2204	298	1233	1902
			setupStore	30	5	271	47	21	153
			numNetworkReqs	74	52	166	28	89	138
	Webpack	Standard Home	uiStartup	1607	1338	2020	152	1672	1905
			load	1324	1135	1624	101	1390	1524
			domContentLoaded	1323	1135	1624	100	1390	1523
			domInteractive	83	31	224	39	110	153
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	19	202	40	70	143
			firstReactRender	16	10	54	5	17	25
			getState	15	6	143	17	14	30
			initialActions	1	0	3	1	2	2
			loadScripts	1287	1116	1567	93	1333	1494
			setupStore	24	6	197	35	18	117
			numNetworkReqs	21	9	92	21	15	80
	Webpack	Power User Home	uiStartup	2586	1692	3529	510	2984	3275
			load	1915	1225	2700	495	2387	2571
			domContentLoaded	1914	1225	2696	495	2387	2571
			domInteractive	64	29	292	48	71	176
			firstPaint	-	-	-	-	-	-
			backgroundConnect	302	26	1247	352	374	1071
			firstReactRender	20	12	65	9	23	36
			getState	124	57	1003	133	127	244
			initialActions	2	0	7	1	2	3
			loadScripts	1672	1191	2527	418	2111	2386
			setupStore	31	5	995	101	22	84
			numNetworkReqs	70	40	146	28	82	137

📊 Page Load Benchmark Results

Current Commit: 7a41f69 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 987ms (±61ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 690ms (±59ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 72ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	987ms	61ms	946ms	1.26s	1.18s	1.26s
domContentLoaded	690ms	59ms	654ms	961ms	886ms	961ms
firstPaint	72ms	10ms	52ms	148ms	84ms	148ms
firstContentfulPaint	72ms	10ms	52ms	148ms	84ms	148ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -75.47 KiB (-1.54%)
ui: -10.01 KiB (-0.13%)
common: -2.69 KiB (-0.03%)

metamaskbotv2 · 2026-01-07T03:10:37Z

Builds ready [7a41f69]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1275 ± 109 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1275	1054	1585	109	1331	1443
			load	1072	875	1318	101	1137	1248
			domContentLoaded	1066	862	1308	100	1129	1239
			domInteractive	26	15	110	21	23	89
			firstPaint	171	66	1155	172	189	339
			backgroundConnect	213	195	271	11	217	235
			firstReactRender	15	9	34	6	16	30
			getState	33	16	70	10	40	51
			initialActions	1	0	7	1	1	2
			loadScripts	860	664	1112	100	922	1032
			setupStore	12	8	51	5	12	20
			numNetworkReqs	17	11	75	17	11	66
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	810	668	1118	89	857	1001
			load	648	583	950	69	660	798
			domContentLoaded	643	578	943	68	653	788
			domInteractive	26	16	95	20	23	83
			firstPaint	105	62	426	57	122	213
			backgroundConnect	28	5	131	28	38	115
			firstReactRender	15	11	36	5	16	26
			getState	34	15	127	19	44	65
			initialActions	1	0	4	1	1	2
			loadScripts	639	576	934	67	651	778
			setupStore	10	6	29	4	11	17
			numNetworkReqs	17	11	74	16	11	66
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1430	1114	2616	230	1532	1835
			load	1145	936	2384	198	1195	1386
			domContentLoaded	1144	936	2383	198	1195	1386
			domInteractive	88	32	1310	129	95	145
			firstPaint	-	-	-	-	-	-
			backgroundConnect	67	19	249	56	114	179
			firstReactRender	14	9	91	10	13	25
			getState	14	6	139	16	12	26
			initialActions	1	0	2	0	1	2
			loadScripts	1102	921	2361	183	1139	1277
			setupStore	17	4	109	21	13	79
			numNetworkReqs	20	9	91	20	14	78
	Browserify	Power User Home	uiStartup	2296	1416	2926	453	2636	2869
			load	1576	969	2355	455	1995	2236
			domContentLoaded	1575	969	2355	455	1994	2234
			domInteractive	75	35	443	69	70	272
			firstPaint	-	-	-	-	-	-
			backgroundConnect	393	20	1057	405	910	1011
			firstReactRender	20	11	62	7	24	26
			getState	82	55	197	23	88	126
			initialActions	2	0	7	1	2	3
			loadScripts	1231	953	2204	298	1233	1902
			setupStore	30	5	271	47	21	153
			numNetworkReqs	74	52	166	28	89	138
	Webpack	Standard Home	uiStartup	1607	1338	2020	152	1672	1905
			load	1324	1135	1624	101	1390	1524
			domContentLoaded	1323	1135	1624	100	1390	1523
			domInteractive	83	31	224	39	110	153
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	19	202	40	70	143
			firstReactRender	16	10	54	5	17	25
			getState	15	6	143	17	14	30
			initialActions	1	0	3	1	2	2
			loadScripts	1287	1116	1567	93	1333	1494
			setupStore	24	6	197	35	18	117
			numNetworkReqs	21	9	92	21	15	80
	Webpack	Power User Home	uiStartup	2586	1692	3529	510	2984	3275
			load	1915	1225	2700	495	2387	2571
			domContentLoaded	1914	1225	2696	495	2387	2571
			domInteractive	64	29	292	48	71	176
			firstPaint	-	-	-	-	-	-
			backgroundConnect	302	26	1247	352	374	1071
			firstReactRender	20	12	65	9	23	36
			getState	124	57	1003	133	127	244
			initialActions	2	0	7	1	2	3
			loadScripts	1672	1191	2527	418	2111	2386
			setupStore	31	5	995	101	22	84
			numNetworkReqs	70	40	146	28	82	137

📊 Page Load Benchmark Results

Current Commit: 7a41f69 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 987ms (±61ms) 🟢 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 690ms (±59ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 72ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	987ms	61ms	946ms	1.26s	1.18s	1.26s
domContentLoaded	690ms	59ms	654ms	961ms	886ms	961ms
firstPaint	72ms	10ms	52ms	148ms	84ms	148ms
firstContentfulPaint	72ms	10ms	52ms	148ms	84ms	148ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -75.47 KiB (-1.54%)
ui: -10.01 KiB (-0.13%)
common: -2.69 KiB (-0.03%)

rekmarks temporarily deployed to pr-comment January 7, 2026 00:54 — with GitHub Actions Inactive

metamaskbot added the team-ocap-kernel The Ocap Kernel team label Jan 7, 2026

github-actions bot added the size-S label Jan 7, 2026

rekmarks temporarily deployed to pr-comment January 7, 2026 01:21 — with GitHub Actions Inactive

rekmarks temporarily deployed to pr-comment January 7, 2026 03:06 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: migrate eth-json-rpc-filters to use JsonRpcEngineV2 #39057

chore: migrate eth-json-rpc-filters to use JsonRpcEngineV2 #39057

rekmarks commented Jan 7, 2026

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: migrate eth-json-rpc-filters to use JsonRpcEngineV2 #39057

Are you sure you want to change the base?

chore: migrate eth-json-rpc-filters to use JsonRpcEngineV2 #39057

Conversation

rekmarks commented Jan 7, 2026

Summary

Test plan

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants