fix: show notice that the account isn't connected when switching accounts - in side panel view #39063

NidhiKJha · 2026-01-07T12:19:29Z

This PR ensures that not connected notification show up for sidepanel. Issue here was that the selector
selectShowConnectAccountToast used state.activeTab.origin directly instead of getOriginOfCurrentTab(state)

Changelog

CHANGELOG entry:null

Related issues

Fixes: #38804

Manual testing steps

Fresh install
Do not open pop-up view only side panel view
Connect to a dapp with account 1
Switch accounts and see the notification appear for not connected account

Screenshots/Recordings

Before

NA

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Fixes connect-account toast logic for side panel contexts.

Use getOriginOfCurrentTab instead of state.activeTab.origin in selectShowConnectAccountToast and selectShowConnectAccountGroupToast to correctly resolve origin in side panel
Explicitly coerce selector results to booleans with Boolean(...)

^{Written by Cursor Bugbot for commit 528b78f. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-01-07T12:51:26Z

Builds ready [f4bc260]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1296 ± 120 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1296	1022	1553	120	1366	1501
			load	1091	874	1346	112	1159	1294
			domContentLoaded	1085	871	1337	111	1150	1286
			domInteractive	26	15	111	21	21	90
			firstPaint	147	65	1088	113	186	276
			backgroundConnect	212	196	242	9	216	232
			firstReactRender	14	9	26	3	15	20
			getState	35	19	73	11	39	54
			initialActions	1	0	5	1	1	2
			loadScripts	880	662	1127	110	946	1088
			setupStore	12	5	37	5	13	24
			numNetworkReqs	18	11	81	18	11	74
	Browserify	Power User Home	uiStartup	1725	1339	2241	165	1800	2037
			load	1062	881	1555	120	1138	1302
			domContentLoaded	1049	876	1542	119	1121	1287
			domInteractive	31	18	147	25	26	100
			firstPaint	189	66	1553	206	208	365
			backgroundConnect	237	197	582	53	247	278
			firstReactRender	14	11	24	2	15	18
			getState	167	123	253	27	185	219
			initialActions	1	0	2	1	1	2
			loadScripts	837	680	1313	115	901	1064
			setupStore	17	6	57	10	16	41
			numNetworkReqs	67	53	207	22	62	120
	Webpack	Standard Home	uiStartup	785	644	997	80	835	928
			load	637	568	794	60	678	756
			domContentLoaded	632	563	788	59	671	750
			domInteractive	24	15	96	18	21	77
			firstPaint	100	57	314	52	108	230
			backgroundConnect	22	5	108	22	28	76
			firstReactRender	16	10	34	5	17	30
			getState	33	15	118	15	42	56
			initialActions	1	0	10	1	1	3
			loadScripts	629	561	779	58	668	741
			setupStore	12	6	44	6	13	26
			numNetworkReqs	17	11	76	17	11	65
	Webpack	Power User Home	uiStartup	1163	928	1559	140	1236	1436
			load	726	597	967	94	802	900
			domContentLoaded	719	591	959	93	797	889
			domInteractive	30	16	145	26	25	104
			firstPaint	124	63	889	100	154	280
			backgroundConnect	63	6	543	125	42	458
			firstReactRender	16	13	23	2	16	20
			getState	136	83	181	14	143	171
			initialActions	1	0	2	0	1	1
			loadScripts	716	589	951	92	792	886
			setupStore	14	8	38	7	14	35
			numNetworkReqs	64	52	121	16	62	111
Firefox	Browserify	Standard Home	uiStartup	1397	1095	2067	197	1476	1831
			load	1119	944	1852	150	1188	1346
			domContentLoaded	1119	944	1852	150	1188	1346
			domInteractive	75	32	255	43	90	160
			firstPaint	-	-	-	-	-	-
			backgroundConnect	57	19	360	54	67	171
			firstReactRender	12	9	39	3	12	16
			getState	18	6	479	49	12	38
			initialActions	1	0	2	0	1	2
			loadScripts	1083	931	1805	133	1143	1290
			setupStore	15	4	155	21	11	49
			numNetworkReqs	19	9	80	19	13	76
	Browserify	Power User Home	uiStartup	2501	1460	3704	554	2937	3135
			load	1716	978	2575	550	2253	2469
			domContentLoaded	1715	978	2574	550	2252	2469
			domInteractive	87	32	895	108	79	272
			firstPaint	-	-	-	-	-	-
			backgroundConnect	334	21	1302	357	412	1109
			firstReactRender	19	10	61	9	24	30
			getState	94	58	149	20	108	138
			initialActions	2	0	3	1	2	2
			loadScripts	1482	961	2390	463	2003	2272
			setupStore	20	4	159	26	19	85
			numNetworkReqs	74	51	175	29	87	144
	Webpack	Standard Home	uiStartup	1642	1320	2191	188	1726	1995
			load	1357	1150	1654	115	1410	1607
			domContentLoaded	1356	1150	1654	115	1410	1606
			domInteractive	85	29	230	44	121	147
			firstPaint	-	-	-	-	-	-
			backgroundConnect	62	19	299	46	73	146
			firstReactRender	16	11	57	6	17	26
			getState	21	6	154	29	16	109
			initialActions	1	0	3	1	2	2
			loadScripts	1321	1129	1590	103	1377	1545
			setupStore	18	4	189	23	17	51
			numNetworkReqs	19	9	86	20	13	78
	Webpack	Power User Home	uiStartup	2701	1653	3887	526	3093	3361
			load	1979	1182	2767	516	2460	2662
			domContentLoaded	1979	1182	2766	516	2459	2662
			domInteractive	79	29	409	81	78	308
			firstPaint	-	-	-	-	-	-
			backgroundConnect	319	26	1148	355	362	1095
			firstReactRender	21	12	76	12	25	53
			getState	119	56	1237	153	107	206
			initialActions	2	0	3	1	2	3
			loadScripts	1722	1159	2590	447	2157	2502
			setupStore	44	5	1041	143	16	186
			numNetworkReqs	75	52	159	31	77	151

📊 Page Load Benchmark Results

Current Commit: f4bc260 | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 715ms (±40ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	44ms	1.00s	1.32s	1.05s	1.32s
domContentLoaded	715ms	40ms	695ms	988ms	729ms	988ms
firstPaint	75ms	10ms	60ms	156ms	84ms	156ms
firstContentfulPaint	75ms	10ms	60ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: -1 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-01-08T15:59:23Z

Builds ready [528b78f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1305 ± 122 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1305	1047	1607	122	1386	1518
			load	1091	871	1355	111	1147	1306
			domContentLoaded	1085	867	1348	110	1142	1293
			domInteractive	26	15	97	18	23	76
			firstPaint	145	65	305	61	191	251
			backgroundConnect	218	197	273	14	222	252
			firstReactRender	16	10	31	4	18	24
			getState	38	21	128	14	41	65
			initialActions	1	0	4	1	1	1
			loadScripts	874	673	1127	109	939	1084
			setupStore	12	6	21	3	12	20
			numNetworkReqs	17	11	68	16	11	64
	Browserify	Power User Home	uiStartup	1921	1465	2440	192	2046	2357
			load	1051	920	1425	119	1079	1324
			domContentLoaded	1037	910	1411	119	1063	1312
			domInteractive	35	17	122	23	35	108
			firstPaint	229	69	1364	219	247	453
			backgroundConnect	262	207	731	99	240	543
			firstReactRender	22	15	42	5	24	34
			getState	172	142	273	25	187	215
			initialActions	1	0	6	1	1	2
			loadScripts	819	701	1198	116	844	1104
			setupStore	18	10	59	8	19	38
			numNetworkReqs	59	37	143	24	63	131
	Webpack	Standard Home	uiStartup	795	648	1063	84	844	975
			load	649	572	884	78	711	800
			domContentLoaded	644	567	880	77	706	795
			domInteractive	24	15	100	17	19	77
			firstPaint	100	59	336	54	103	214
			backgroundConnect	28	5	135	30	35	93
			firstReactRender	15	11	39	5	15	27
			getState	30	15	132	16	40	52
			initialActions	1	0	4	1	1	1
			loadScripts	641	564	871	76	700	793
			setupStore	12	7	44	7	12	32
			numNetworkReqs	18	11	81	17	11	67
	Webpack	Power User Home	uiStartup	1399	1027	2267	281	1506	2001
			load	704	601	1195	93	733	907
			domContentLoaded	694	595	1187	94	714	901
			domInteractive	37	18	164	30	34	126
			firstPaint	135	67	388	71	165	295
			backgroundConnect	82	7	659	177	21	617
			firstReactRender	23	18	39	3	24	29
			getState	151	133	204	12	159	170
			initialActions	1	0	4	1	1	2
			loadScripts	690	592	1176	92	711	891
			setupStore	16	10	50	7	17	41
			numNetworkReqs	99	40	244	46	135	206
Firefox	Browserify	Standard Home	uiStartup	1384	1080	2045	169	1458	1683
			load	1092	922	1386	101	1150	1268
			domContentLoaded	1091	918	1386	101	1150	1268
			domInteractive	74	32	250	43	89	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	20	305	51	64	169
			firstReactRender	12	10	38	3	12	17
			getState	13	7	155	16	11	27
			initialActions	1	0	3	1	1	2
			loadScripts	1058	908	1262	84	1100	1222
			setupStore	15	6	202	25	11	52
			numNetworkReqs	19	9	81	19	13	75
	Browserify	Power User Home	uiStartup	2563	2015	5374	613	2591	4069
			load	1284	986	2695	378	1277	2601
			domContentLoaded	1284	986	2695	378	1276	2600
			domInteractive	133	32	756	124	123	448
			firstPaint	-	-	-	-	-	-
			backgroundConnect	148	23	1205	225	117	868
			firstReactRender	24	15	87	11	26	33
			getState	277	70	896	219	444	743
			initialActions	2	0	7	1	2	3
			loadScripts	1233	944	2671	337	1184	2079
			setupStore	158	6	791	199	188	687
			numNetworkReqs	59	30	256	48	48	193
	Webpack	Standard Home	uiStartup	1653	1348	2593	214	1798	2071
			load	1364	1161	2032	131	1443	1567
			domContentLoaded	1363	1161	2032	131	1443	1567
			domInteractive	75	29	230	40	93	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	68	21	233	50	99	170
			firstReactRender	15	11	30	3	16	21
			getState	25	8	223	37	18	110
			initialActions	1	0	3	1	2	2
			loadScripts	1322	1141	1915	114	1388	1532
			setupStore	21	5	260	36	15	90
			numNetworkReqs	20	9	91	20	14	79
	Webpack	Power User Home	uiStartup	2939	2190	6495	898	3098	4740
			load	1630	1172	5020	636	1677	2923
			domContentLoaded	1630	1172	5020	636	1677	2923
			domInteractive	131	30	3196	320	102	384
			firstPaint	-	-	-	-	-	-
			backgroundConnect	185	23	1955	295	170	1067
			firstReactRender	25	15	258	25	25	35
			getState	262	67	908	211	381	752
			initialActions	2	0	4	1	2	3
			loadScripts	1529	1156	4999	542	1598	2675
			setupStore	95	6	1126	163	79	495
			numNetworkReqs	57	29	189	33	83	117

📊 Page Load Benchmark Results

Current Commit: 528b78f | Date: 1/8/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±35ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1.00s	1.30s	1.06s	1.30s
domContentLoaded	721ms	35ms	696ms	964ms	745ms	964ms
firstPaint	77ms	11ms	60ms	172ms	84ms	172ms
firstContentfulPaint	77ms	11ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.74 KiB (0.04%)
ui: -1.14 KiB (-0.01%)
common: 6.28 KiB (0.07%)

updated active tab logic

f4bc260

NidhiKJha temporarily deployed to pr-comment January 7, 2026 12:19 — with GitHub Actions Inactive

metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 7, 2026

github-actions bot added the size-XS label Jan 7, 2026

NidhiKJha temporarily deployed to pr-comment January 7, 2026 12:47 — with GitHub Actions Inactive

AndyMBridges previously approved these changes Jan 8, 2026

View reviewed changes

type fix

528b78f

NidhiKJha dismissed AndyMBridges’s stale review via 528b78f January 8, 2026 15:25

NidhiKJha temporarily deployed to pr-comment January 8, 2026 15:25 — with GitHub Actions Inactive

NidhiKJha requested a review from AndyMBridges January 8, 2026 15:25

NidhiKJha temporarily deployed to pr-comment January 8, 2026 15:55 — with GitHub Actions Inactive

AndyMBridges approved these changes Jan 8, 2026

View reviewed changes

n3ps approved these changes Jan 8, 2026

View reviewed changes

NidhiKJha added this pull request to the merge queue Jan 9, 2026

Merged via the queue into main with commit bfd50d7 Jan 9, 2026
176 checks passed

NidhiKJha deleted the fix-38804 branch January 9, 2026 10:03

github-actions bot locked and limited conversation to collaborators Jan 9, 2026

metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: show notice that the account isn't connected when switching accounts - in side panel view #39063

fix: show notice that the account isn't connected when switching accounts - in side panel view #39063

NidhiKJha commented Jan 7, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 8, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: show notice that the account isn't connected when switching accounts - in side panel view #39063

fix: show notice that the account isn't connected when switching accounts - in side panel view #39063

Conversation

NidhiKJha commented Jan 7, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 8, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NidhiKJha commented Jan 7, 2026 •

edited by cursor bot

Loading