fix: fix network switch from dapp permission popover #39064
Draft
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +4 -3)
|
sahar-fehri
commented
Jan 7, 2026
|
|
||
| dispatch( | ||
| setNetworkClientIdForDomain(selectedTabOrigin, finalNetworkClientId), | ||
| await setNetworkClientIdForDomain( |
Contributor
Author
There was a problem hiding this comment.
setNetworkClientIdForDomain returns a Promise, not a Redux thunk. The code was incorrectly wrapping this function call with dispatch():
This caused the execution to fail silently, preventing setActiveNetwork from being reached.
Contributor
There was a problem hiding this comment.
Great find! That does look like it's fixed it. Though I think the part that filters the global network menu is setEnabledNetworks not setActiveNetwork, right? Not totally sure what setActiveNetwork is supposed to do.
Contributor
Author
There was a problem hiding this comment.
I think that the setActiveNetwork is what switches the network; it calls the networkController.
The setEnabledNetworks; controls which networks appear in the network list UI
Just updates enabledNetworkMap state and it calls the networkEnablementController
Contributor
Builds ready [9880904]
UI Startup Metrics (1273 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When clicking on an EVM network from the dapp connected site popover (the network button shown when a dapp is connected), the network would not switch on the home page. However, selecting a non-EVM network from the same menu would correctly switch the network.
Looking at the code, the intention was clearly for EVM networks to switch when selected - the
handleEvmNetworkChangefunction callssetActiveNetwork(finalNetworkClientId)which should update the globally selected network. However, this was silently failing.Non-EVM networks worked correctly because handleNonEvmNetworkChange does not have the dapp-specific code block that calls setNetworkClientIdForDomain. It simply calls setActiveNetwork(chainId) directly without going through the problematic code path
Changelog
CHANGELOG entry: Fixing a bug to allow switching evm networks on main page when selected from dapp connected site popover.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist