Skip to content

Conversation

@NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Jan 7, 2026

Since we have updated the manifest for main directly, we don't need a manifest for experimental. Also, this is breaking the FF behaviour because sidepanel is added directly for experimental manifest

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

  1. Everything should work in both experimental and main builds for FF and chrome

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the experimental build manifest to rely on the main manifest and avoid duplicate side panel config.

  • Deletes app/build-types/experimental/manifest/_base.json, which specified permissions: ["sidePanel"] and side_panel.default_path

Written by Cursor Bugbot for commit bb192f4. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 7, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 7, 2026

Builds ready [0bc73ce]
UI Startup Metrics (1277 ± 117 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12771022173511713341476
load1074865141910511271266
domContentLoaded1068858141610411201258
domInteractive261599202383
firstPaint1446733164179309
backgroundConnect21819628611222233
firstReactRender1482941626
getState4218109184794
initialActions105112
loadScripts85765111901049111056
setupStore1365571525
numNetworkReqs171178161165
BrowserifyPower User HomeuiStartup17261443229717718002088
load1055892158311011141226
domContentLoaded1043883152910711031219
domInteractive2917105192887
firstPaint164681102117209295
backgroundConnect24320057062246425
firstReactRender14112521519
getState17112829733189232
initialActions104112
loadScripts82868113041058891015
setupStore18646101840
numNetworkReqs68532172663124
WebpackStandard HomeuiStartup8116641114888521001
load65358788565685787
domContentLoaded64858387965680778
domInteractive2516142202278
firstPaint1085939557132213
backgroundConnect245112253495
firstReactRender16104051825
getState3514124174660
initialActions104114
loadScripts64558087163678775
setupStore1374281436
numNetworkReqs171179161167
WebpackPower User HomeuiStartup1151913196617112171489
load70559090478731872
domContentLoaded69958489577724863
domInteractive3016120242599
firstPaint1236341164152230
backgroundConnect58756011455476
firstReactRender15122321619
getState1357820315139160
initialActions102011
loadScripts69658289375721860
setupStore1477181336
numNetworkReqs66531271763115
FirefoxBrowserifyStandard HomeuiStartup13711059204619614861704
load1096909185713311701299
domContentLoaded1095908185713311701299
domInteractive67321853787138
firstPaint------
backgroundConnect62193866177191
firstReactRender1293131220
getState156113181339
initialActions102012
loadScripts1060894183712011221201
setupStore165173221361
numNetworkReqs19977191373
BrowserifyPower User HomeuiStartup25721544341756930493332
load17671028271557123082559
domContentLoaded17671027271457123082559
domInteractive1083495214389314
firstPaint------
backgroundConnect3432412033634561154
firstReactRender211274102546
getState1106149151123198
initialActions218123
loadScripts15261013246849321302367
setupStore215149252274
numNetworkReqs75521783183164
WebpackStandard HomeuiStartup15651293202316116521856
load13151126155710913911527
domContentLoaded13141126155710913911527
domInteractive782417637106139
firstPaint------
backgroundConnect61172094277144
firstReactRender15117991522
getState156118191237
initialActions103122
loadScripts1276110515319713421442
setupStore175230261263
numNetworkReqs19985181373
WebpackPower User HomeuiStartup24821586317844728603041
load18421074254046822892425
domContentLoaded18421074253946822882425
domInteractive66323085168224
firstPaint------
backgroundConnect231241090260280976
firstReactRender19136172231
getState925926738102168
initialActions207123
loadScripts16721059231338920432225
setupStore68595718621341
numNetworkReqs69411583081133
📊 Page Load Benchmark Results

Current Commit: 0bc73ce | Date: 1/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 726ms (±36ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.32s 1.07s 1.32s
domContentLoaded 726ms 36ms 700ms 988ms 755ms 988ms
firstPaint 77ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 77ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 8, 2026

Builds ready [bb192f4]
UI Startup Metrics (1241 ± 125 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12411011163412513141489
load1042822137412011111278
domContentLoaded1035815136811911051272
domInteractive2315112181977
firstPaint1905712942361841083
backgroundConnect19717323312205222
firstReactRender1483351525
getState331869113955
initialActions103112
loadScripts84662911691219211088
setupStore1374051422
numNetworkReqs181178171173
BrowserifyPower User HomeuiStartup18901514254719820052339
load1026886144611210561265
domContentLoaded1013879143811310431253
domInteractive35171452633115
firstPaint189731354143227398
backgroundConnect272203769134231632
firstReactRender21154972242
getState18113474082185222
initialActions103112
loadScripts80468012351128371045
setupStore1911156161939
numNetworkReqs57341442261119
WebpackStandard HomeuiStartup784649104975813961
load63656080964664787
domContentLoaded63155680363658782
domInteractive2615101202287
firstPaint1036132950122219
backgroundConnect3151443148105
firstReactRender14102731621
getState3213123164259
initialActions106111
loadScripts62855479462655774
setupStore1264581337
numNetworkReqs181176181173
WebpackPower User HomeuiStartup1361971204024415241917
load697593100892712946
domContentLoaded688589100293702939
domInteractive36181723232127
firstPaint1386344580164335
backgroundConnect101765518278584
firstReactRender22173842328
getState15913375862161193
initialActions103112
loadScripts68458699291699930
setupStore1586371719
numNetworkReqs73382334181150
FirefoxBrowserifyStandard HomeuiStartup14061094208920115051842
load1114935190115111951349
domContentLoaded1113935190015211941348
domInteractive81329329895183
firstPaint------
backgroundConnect58162625067169
firstReactRender1292531217
getState156205251242
initialActions102122
loadScripts1078915188613611311267
setupStore154170241148
numNetworkReqs20992201475
BrowserifyPower User HomeuiStartup24821809797678624644382
load1262993528949312391990
domContentLoaded1261993528849312391990
domInteractive138351000150121400
firstPaint------
backgroundConnect125261279207102430
firstReactRender22158782429
getState25367831206324729
initialActions203123
loadScripts1220978525847811761865
setupStore1279768181113611
numNetworkReqs722925749104178
WebpackStandard HomeuiStartup15941216217917817221915
load13251111165711814051528
domContentLoaded13241110165611814051527
domInteractive78272083896144
firstPaint------
backgroundConnect68202945587182
firstReactRender15115771626
getState168213211529
initialActions102122
loadScripts12841093152610413661474
setupStore2632103818120
numNetworkReqs20982191375
WebpackPower User HomeuiStartup28722158486677328964651
load16151228328353117652820
domContentLoaded16141227328353117652819
domInteractive11830963143105549
firstPaint------
backgroundConnect1782212712571491034
firstReactRender2515123162859
getState27670810224418778
initialActions203123
loadScripts15101192310843315882708
setupStore1137565130158457
numNetworkReqs58281864351174
📊 Page Load Benchmark Results

Current Commit: bb192f4 | Date: 1/8/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 41ms 1.02s 1.35s 1.07s 1.35s
domContentLoaded 730ms 38ms 705ms 1.02s 751ms 1.02s
firstPaint 78ms 10ms 60ms 160ms 88ms 160ms
firstContentfulPaint 78ms 10ms 60ms 160ms 88ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 5bd5943 Jan 8, 2026
333 of 335 checks passed
@NidhiKJha NidhiKJha deleted the remove-manifest branch January 8, 2026 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
@metamaskbot metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.14.0 Issue or pull request that will be included in release 13.14.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants