chore: Enable key caching of keyring controller

[tommasini]

Description

This PR enables the caching of the key, feature provided by the keyring controller.

Related issues

Fixes:

Manual testing steps

1. Import via SRP
2. Import via private key

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 12fc46f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b082f60-1b64-4cd0-8a1f-a2b8981e878f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8675071
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3e09f56-9d96-485a-a786-8a75fa12a1bb

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[mikesposito]

Can we change the type that WithKeyEncryptor is extending, from GenericEncryptor to ExportableKeyEncryptor?

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: b43d25e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17494756-f20e-44fe-95d0-9f4fecd67aab

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.21%. Comparing base (256bc97) to head (b43d25e).
Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13675      +/-   ##
==========================================
+ Coverage   62.91%   63.21%   +0.30%     
==========================================
  Files        2035     2075      +40     
  Lines       44539    45102     +563     
  Branches     6050     6199     +149     
==========================================
+ Hits        28020    28513     +493     
- Misses      14685    14710      +25     
- Partials     1834     1879      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikesposito]

Looks good!
I opened a PR on core to make ExportableKeyEncryptor generic and remove those ts-expect-error: MetaMask/core#5395

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 91fda0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e8ddc14-2e9d-4afc-8a81-f370aff7b6f8

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0126052
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/736f5f52-f2e7-4d4f-9fcc-4e6d4e66e5b2

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2017f1f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1b0e19b-67e6-4531-a95c-e8623913830b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud