Skip to content

chore: adds two metric events for multichain transactions #15021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zone-live
Copy link
Contributor

Description

We are listening for two events transactionConfirmed and transactionSubmitted from the multichain transactions controller and then sending out the necessary metrics with trackEvent.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the Run Smoke E2E Requires smoke E2E testing label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1031708
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/108c10c7-5222-4e19-86cd-a5dbfecb9a76

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@zone-live zone-live added the No QA Needed Apply this label when your PR does not need any QA effort. label May 5, 2025
@zone-live zone-live marked this pull request as ready for review May 5, 2025 13:52
@zone-live zone-live requested a review from a team as a code owner May 5, 2025 13:52
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-solana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants