-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
test: Create anvil manager class #15046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15046 +/- ##
==========================================
- Coverage 67.84% 67.80% -0.05%
==========================================
Files 2343 2353 +10
Lines 50476 50746 +270
Branches 7452 7494 +42
==========================================
+ Hits 34246 34408 +162
- Misses 14062 14149 +87
- Partials 2168 2189 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
It seems that we are missing a dependency accordingly with the CI |
solid catch @tommasini, i was indeed missing a dependency. added it to the package json now 🙏 |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Just curious about updating the e2e project docs and how you want to handle that?
@chrisleewilcox yeah once we have fully migrated to anvil, i will update the docs! right now this PR is one of many PRs |
Description
This is part 2/3 of Anvil Utils. The purpose of this PR is to add an AnvilManager class, which is essentially a wrapper around @viem/anvil that manages an anvil instance that will be used in our tests. It includes:
getProvider()
method that returns wallet, public, and test clientsRelated issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-524
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist