Skip to content

feat: Adding support for wallet_getCapabilities #15047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 14, 2025
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 1, 2025

Description

Adding support for wallet_getCapabilities

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4790

Manual testing steps

  1. Go to test dapp
  2. Click Get Capabilities button and check the result

Screenshots/Recordings

Screenshot 2025-05-01 at 7 55 48 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label May 1, 2025
@jpuri jpuri requested a review from a team as a code owner May 1, 2025 02:28
Copy link
Contributor

github-actions bot commented May 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge May 13, 2025 10:57
ffmcgee725
ffmcgee725 previously approved these changes May 13, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (5113000) to head (e8644a1).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
app/core/RPCMethods/eip5792.ts 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15047      +/-   ##
==========================================
+ Coverage   68.46%   68.69%   +0.23%     
==========================================
  Files        2372     2379       +7     
  Lines       51275    51426     +151     
  Branches     7634     7663      +29     
==========================================
+ Hits        35103    35328     +225     
+ Misses      13942    13852      -90     
- Partials     2230     2246      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpuri jpuri added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 13, 2025
Copy link
Contributor

github-actions bot commented May 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: afac730
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2a233df-e2e5-4da9-8527-29cc3e1b9540

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 13, 2025
Copy link
Contributor

github-actions bot commented May 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a13a665
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e0ad7bd6-74ed-4858-a4e5-f92a236f2312

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

matthewwalsh0
matthewwalsh0 previously approved these changes May 13, 2025
@jpuri jpuri dismissed stale reviews from matthewwalsh0 and ffmcgee725 via 0d7293f May 13, 2025 15:52
Copy link

@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels May 14, 2025
@jpuri
Copy link
Contributor Author

jpuri commented May 14, 2025

Ignoring bitrise it is currently broken for almost all PRs

@jpuri jpuri added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 60820d8 May 14, 2025
43 of 47 checks passed
@jpuri jpuri deleted the support_get_capabilities branch May 14, 2025 09:54
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants