Skip to content

fix: bump @metamask/keyring-controller to ^21.0.5 #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

Description

If a user has duplicate accounts in the state and vault with outdated encryption params, the login fails with the following message under the password field: KeyringController - The account you are trying to import is a duplicate.

KeyringController 21.0.5 includes a fix for this issue:

### Fixed

- The vault encryption upgrade fails grecefully during login ([#5740](https://github.com/MetaMask/core/pull/5740))

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito requested a review from a team as a code owner May 1, 2025 21:36
Copy link

socket-security bot commented May 1, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​keyring-controller@​21.0.4 ⏵ 21.0.592 +110076 +199 +1100

View full report

@mikesposito mikesposito added the Run Smoke E2E Requires smoke E2E testing label May 1, 2025
Copy link
Contributor

github-actions bot commented May 1, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 042af7a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/185e9b71-f08b-4a82-899a-36e547762652

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.77%. Comparing base (25ed17c) to head (042af7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15066   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files        2344     2344           
  Lines       50621    50621           
  Branches     7484     7484           
=======================================
  Hits        34306    34306           
  Misses      14135    14135           
  Partials     2180     2180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented May 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Requires smoke E2E testing team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants