Skip to content

fix: cp-7.46.0 show bridge button when the mobile feature flag is off and redirect to Portfolio #15088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2025
Merged

fix: cp-7.46.0 show bridge button when the mobile feature flag is off and redirect to Portfolio #15088

merged 5 commits into from
May 5, 2025
+137 −29

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented May 2, 2025 •
edited
Loading

Description

This PR fixes an issue where the Bridge button doesn't appear. It will now appear and redirect you to Portfolio when the feature flags for Mobile are turned off.

Related issues

Fixes:

Manual testing steps

  1. Open the wallet actions
  2. Bridge button should be there
  3. Make sure LD flags for bridge are disabled
  4. Click Bridge buton
  5. Should be sent to Portfolio

Do the same as above but by going to an asset first

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-02.at.4.18.47.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@infiniteflower infiniteflower marked this pull request as ready for review May 2, 2025 19:38
@infiniteflower infiniteflower requested review from a team as code owners May 2, 2025 19:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower changed the title fix: show bridge button when the mobile feature flag is off and redir… fix: cp-7.46.0 show bridge button when the mobile feature flag is off and redir… May 2, 2025
@infiniteflower infiniteflower added the Run Smoke E2E Requires smoke E2E testing label May 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62fe9c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c02f746-d5c2-401a-ad1c-d20fe1ba5660

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@infiniteflower infiniteflower added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3658a63
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cebc9c8f-46e9-4ec6-9679-f0dbbbd66e11

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@infiniteflower infiniteflower added QA Passed QA testing has been completed and passed Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0aab590
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d81f236-596b-40b9-8797-764035a9326f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

amitabh94
amitabh94 previously approved these changes May 2, 2025
View reviewed changes
@sahar-fehri
Copy link
Contributor

Could you update the title and description of this PR 🙏
I think you meant to write this in desc: show bridge button when the mobile feature flag is off and redirect to portfolio?

sahar-fehri
sahar-fehri previously approved these changes May 2, 2025
View reviewed changes
@infiniteflower infiniteflower dismissed stale reviews from sahar-fehri and amitabh94 via d259281 May 5, 2025 14:26
@infiniteflower infiniteflower changed the title fix: cp-7.46.0 show bridge button when the mobile feature flag is off and redir… fix: cp-7.46.0 show bridge button when the mobile feature flag is off and redirect to Portfolio May 5, 2025
@infiniteflower infiniteflower added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d259281
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/088b2cbd-df4d-4ec6-a801-ec4487c64308

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@infiniteflower infiniteflower enabled auto-merge May 5, 2025 14:31
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@infiniteflower infiniteflower added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit ecf309c May 5, 2025
53 of 55 checks passed
@infiniteflower infiniteflower deleted the mms-2181-bridge-disabled-portfolio-link branch May 5, 2025 15:18
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GustavoRSSilva GustavoRSSilva GustavoRSSilva approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Requires smoke E2E testing team-swaps-and-bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@infiniteflower @sahar-fehri @GustavoRSSilva @amitabh94 @metamaskbot