Skip to content

chore: add expo flask dev & sim builds #15093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2025
Merged

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented May 2, 2025

Description

This PR adds 3 new workflows that allow devs to build flask binaries for expo.

It also deletes a duplicate build build_android_flask_release

  • build_android_flask_devbuild
  • build_ios_flask_devbuild
  • build_ios_flask_simbuild

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

iOS Sim Build: https://app.bitrise.io/build/55b78bbf-98ef-4980-9435-0cf802d9a11d
Android Phone/Emulator: https://app.bitrise.io/build/e3da37f0-cd91-4c19-8710-0d645d19772c
iOS Phone: https://app.bitrise.io/build/fbd0f709-2111-4739-b7bc-17b6cdcf05e1

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner May 2, 2025 21:43
Copy link
Contributor

github-actions bot commented May 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label May 2, 2025
Copy link

sonarqubecloud bot commented May 6, 2025

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run team-dev-ops DevOps team labels May 6, 2025
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@sethkfman sethkfman added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 7e66551 May 7, 2025
56 of 58 checks passed
@sethkfman sethkfman deleted the chore/add-flask-sim-builds branch May 7, 2025 00:29
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-dev-ops DevOps team team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants