Skip to content

fix: cp-7.46.0 Temporarily disable send flow via token details on non-evm networks #15096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented May 3, 2025

Description

It looks like Send flow via the Token Details screen is not supported as of 7.46. There is another PR opened that begins to implement this: #15095

This PR can be used as a cherry-pick in the meantime into 7.46 to disable send flow via tokens details for non-evm networks.

Worth mentioning that users can still enter the send flow via the main tokens screen.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screen.Recording.2025-05-03.at.4.23.24.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added the Run Smoke E2E Requires smoke E2E testing label May 3, 2025
Copy link
Contributor

github-actions bot commented May 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 53853e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eead4559-5896-4ea6-80d0-4a37695963d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added the QA Passed QA testing has been completed and passed label May 3, 2025
@gambinish gambinish changed the title fix: Temporarily disable send flow via token details on non-evm networks fix: cp-7.46.0 Temporarily disable send flow via token details on non-evm networks May 3, 2025
@gambinish gambinish added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 3, 2025
@MetaMask MetaMask deleted a comment from github-actions bot May 3, 2025
@gambinish gambinish added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 3, 2025
Copy link
Contributor

github-actions bot commented May 3, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7eec7b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c20df0a0-4482-40d0-bda0-baa48e65a5ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented May 3, 2025

@gambinish gambinish added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels May 3, 2025
@gambinish gambinish marked this pull request as ready for review May 3, 2025 14:12
@gambinish gambinish requested a review from a team as a code owner May 3, 2025 14:12
@gambinish gambinish added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 276e723 May 5, 2025
55 of 58 checks passed
@gambinish gambinish deleted the fix/disable-send-solana-token-details branch May 5, 2025 15:47
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Requires smoke E2E testing team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants