Skip to content

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Aug 25, 2025

Allow all assigned contributors for this repo to review PRs.

The @MetaMask/devs GitHub team was deprecated a long time ago;
@MetaMask/engineering is the current team that encompasses all of
MetaMask and contains more people. This commit corrects the codeowners
for this repo accordingly.
cryptodev-2s
cryptodev-2s previously approved these changes Aug 25, 2025
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Aug 25, 2025

We should consider removing this instead of using engineering. It has a similar impact except without annoying notifications

@mcmire
Copy link
Contributor Author

mcmire commented Aug 28, 2025

@Gudahtt Are you suggesting that we have no CODEOWNERS file at all, or that we should just leave it empty?

Rely on the permissions set on the repo level.
@mcmire mcmire changed the title Fix codeowners Remove CODEOWNERS Sep 5, 2025
@mcmire
Copy link
Contributor Author

mcmire commented Sep 5, 2025

Okay, I've removed CODEOWNERS entirely.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants